Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chart/redis-ha][REQUEST] use fullname template in test container name #227

Open
elchenberg opened this issue Sep 2, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@elchenberg
Copy link

This is a non-issue but if you are open to it I would be happy to open a pull request. 🙂

Is your feature request related to a problem? Please describe.

The name of the test container uses .Release.Name and not template "redis-ha.fullname". When I install the redis-ha chart as a dependency of a different chart, for example "trivy", the name of the container changes from "redis-ha-service-test" to "trivy-service-test" (wich might be confusing).

Describe the solution you'd like

template "redis-ha.fullname" is used for the container name.

Describe alternatives you've considered

  • not changing the container name because it does not really matter
  • use a hardcoded name like redis-ha-service-test or redis-service-test

Additional context
Add any other context or screenshots about the feature request here.

@elchenberg elchenberg added the enhancement New feature or request label Sep 2, 2022
@DandyDeveloper
Copy link
Owner

@elchenberg On it, might take a couple of days as I have limited PC time. Very quick change and makes sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants