Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Allows Http protocol configuration #61

Open
ByronCobb opened this issue Jan 12, 2022 · 4 comments
Open

[Enhancement] Allows Http protocol configuration #61

ByronCobb opened this issue Jan 12, 2022 · 4 comments
Assignees
Labels
help wanted Extra attention is needed

Comments

@ByronCobb
Copy link

First off, thank you for this library, it works great.
I deployed this to an app I am working on and noticed that although I am running on https, I was being redirected back to http

I've temporarily created a fork to get around this. This is what I have done for now
image

@Dan6erbond Dan6erbond self-assigned this Jan 12, 2022
@Dan6erbond Dan6erbond added the help wanted Extra attention is needed label Jan 12, 2022
@ByronCobb
Copy link
Author

@Dan6erbond I can open a PR with my changes, but I don't feel I know the wider scope of the code so I'm not sure if this simple config is the right thing overall.

@moreorover
Copy link

The protocol can be set when creating a SvelteKitAuth object.

export const appAuth: SvelteKitAuth = new SvelteKitAuth({ providers: [oauthProvider], protocol: 'http' });

@moreorover
Copy link

Apologies, this has been fixed quite a while ago. Perhaps this should be closed?

@vhscom
Copy link
Contributor

vhscom commented Jun 13, 2022

I had some issues related to scheme and ended up monkeypatching getCallbackUri. If this would address that code smell, I'm of the mind this should be left open for visibility.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants