Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CAD mapping algorithms for pyramid elements #1012

Closed
jfussbro opened this issue Apr 5, 2024 · 1 comment
Closed

CAD mapping algorithms for pyramid elements #1012

jfussbro opened this issue Apr 5, 2024 · 1 comment
Assignees
Labels
New feature Adds a new feature to the code tests

Comments

@jfussbro
Copy link
Contributor

jfussbro commented Apr 5, 2024

Since t8code already covers CAD interpolation/mapping for quadrilateral and triangle elements (2D) and for hexahedra, tetrahedra and prisms (PR: #971), the last remaining element type is the pyramid.
A test for the pyramids already exists (PR: #1036 )

For this issue, tests have already been implemented at
[test/t8_geometry/t8_geometry_implementations/t8_gtest_geometry.cxx/DISABLED_t8_gtest_geometry_cad_pyramid, linked_faces]
[test/t8_geometry/t8_geometry_implementations/t8_gtest_geometry.cxx/DISABLED_t8_gtest_geometry_cad_pyramid, linked_edges].
Remember to enable the tests by removing any DISABLED_ in the names when you start working on this issue, or to use --gtest_also_run_disabled_tests during execution of the test.

@jfussbro jfussbro added New feature Adds a new feature to the code tests labels Apr 5, 2024
@jfussbro jfussbro mentioned this issue Apr 5, 2024
14 tasks
@jfussbro jfussbro self-assigned this Apr 8, 2024
@jfussbro
Copy link
Contributor Author

jfussbro commented May 7, 2024

The test is merged and the algorithm is in review.

@jfussbro jfussbro closed this as completed May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
New feature Adds a new feature to the code tests
Projects
None yet
Development

No branches or pull requests

1 participant