-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fps display in the progress text should better be instant ? #9
Comments
I personally think that average fps is more meaningful then instant. But sure, I'll consider it and probably make an option to calculate fps with different strategies. |
I totally agree that all fps methods have uses and pros and cons indeed. Thanks for anything you would do 😄 ! |
Just an idea: |
@Dendraspis agreed, "pure" instant values have no use at all ! However, the |
I have added an element of information here: Patman86/x265-Mod-by-Patman#4 Hopefully, "someone" will take a look at it 😁 |
Unfortunately I don't have much time to look into that feature in few weeks or so, as I've got a load of work 😞 |
Hello @DJATOM !
Currently the progress text of x265 shows important information, all calculated properly, but it seems that fps is calculated as average from the beginning:
fps = (nb of frames processed since beginning) / (time elapsed since beginning).
This gives a idea of the global behavior in the process.
However, fps is a bench-marking information. It has to reflect current status of processing speed.
Let's say, there is suddenly another process launched on the computer, then the fps should almost immediately drop. But it doesn't because the fps is a long term average here. So, I suggest:
fps = (nb of frames processed on a sliding window, or in a buffer) / (time used to process those frames)
That of course, is in my humble opinion.
And thanks always for the great work!
The text was updated successfully, but these errors were encountered: