Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Target Runner Returned Number #18

Open
DE0CH opened this issue Dec 5, 2022 · 2 comments
Open

Target Runner Returned Number #18

DE0CH opened this issue Dec 5, 2022 · 2 comments

Comments

@DE0CH
Copy link
Owner

DE0CH commented Dec 5, 2022

Previously, if the target runner runs out of budget, it returns Inf for cost and 0 for time. Nguyen suggested changing it to Inf for cost and 0 for time if the budget is the same as the maxmium evaluation set by us, then return Inf and 0, otherwise if the bound is given by irace, we return bound + 1 for both cost and time.

This creates an issue because the current code does not reflect the configuration of previous runs, and makes the result not reproducable.

@DE0CH
Copy link
Owner Author

DE0CH commented Jan 26, 2023

Previous runs? Which previous runs? Did we even re-run them all? I don't remember. Oh no.

@DE0CH
Copy link
Owner Author

DE0CH commented Feb 9, 2023

Seems like the config that is not propagated are all the things before binning_with_defaults, before commit 2dc1a4a6ad20d610e5d5f7ae7a91813840ba0e47 but the n = 2000 for iterative_seeding_sizes was rerun with the new behaviour.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant