Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data array dimensions #13

Open
dbpodrasky opened this issue Nov 16, 2022 · 1 comment
Open

Data array dimensions #13

dbpodrasky opened this issue Nov 16, 2022 · 1 comment

Comments

@dbpodrasky
Copy link

Not strictly required when using a typical HDF5 reader, but including the dimensions of the data array---number of time samples and number of receiver channels---in the das dictionary object defined DAS_Format_reference.py would be potentially useful.

@dcbowden
Copy link

dcbowden commented Dec 2, 2022

+1 vote for this from me. I've found it useful (in other codes) to have wrapper functions that can calculate vectors of times and distances, in the case that only a small subset of file needs to be loaded. This is a beautiful thing about HDF5, that one can specify exact indices and load only as needed.
If it's not a header in meta, alternatively maybe the size of the array can be gleaned from the HDF5 dataset properties, and then a little class function can help users get nchannels and nsamples?

Edit: though I realize that what I'm suggesting (pulling only a subset of the data array) would require even further manipulation/modification of the class functions (e.g. get_data() with additional arguments), in which case a user is presumably smart enough to get these dimensions themselves?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants