Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shakers~ improvements #49

Closed
isabelgk opened this issue Dec 22, 2020 · 1 comment
Closed

shakers~ improvements #49

isabelgk opened this issue Dec 22, 2020 · 1 comment

Comments

@isabelgk
Copy link
Contributor

Fix building/linking issues

Use attributes for energy, decay, numobjects, resfreq, and type.

Fix noteon messages. It seems like the noteon message's frequency is changing which type is playing. So playing a C4 plays a maraca and a D4 plays a cabasa, or something along those lines. I suspect fixing the message parsing and using attributes will help fix this...

@isabelgk
Copy link
Contributor Author

Instead of changing noteon functionality (a breaking change), consider creating a new message play which takes an instrument and amplitude which will have the correct functionality (according to the STK noteon function, the help patch, and my own intuition)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant