Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FORCING classes have hardcoded path to forcing data #7

Open
tingeman opened this issue Dec 9, 2020 · 0 comments
Open

FORCING classes have hardcoded path to forcing data #7

tingeman opened this issue Dec 9, 2020 · 0 comments

Comments

@tingeman
Copy link
Collaborator

tingeman commented Dec 9, 2020

With the recent code restructuring, FORCING classes no longer receive the forcing data path specified in the run file.
Instead, FORCING classes have hardcoded forcing paths.

In the new PPROVIDER class, all classes are instantiated the same, and therefore we cannot pass specific parameters to some instantiated classes.

Possible solutions:

  • Pass all paths (result_path and forcing_path) to all instantiated classes, even those who don't need them
  • Pass the PPROVIDER instance to new_class during initialization, and let the class itself grab additional parameters it might need from the PPROVIDER instance
  • Require user to manually set the forcing_path after instantiation. In practice this would be handled by the TILE class right after retreiving the FORCING instance from the PPROVIDER

Which would be the better way?
Other suggestions?

tingeman added a commit that referenced this issue Oct 25, 2022
Pull newest updates from CryoGrid/CryoGrid
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant