Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some equipment isn't hidden when player's equipment is hidden #7269

Open
argxentakato opened this issue Jan 8, 2025 · 0 comments
Open

Some equipment isn't hidden when player's equipment is hidden #7269

argxentakato opened this issue Jan 8, 2025 · 0 comments
Labels
type: bug Issue where something isn't working

Comments

@argxentakato
Copy link

argxentakato commented Jan 8, 2025

Description

When trying to apply mods that hide armour, like Figura to the Create's equipment, some equipment might be hidden and some might not.

The following two examples show backtanks hidden in Figura. Avatar used here: Test.zip

Results for copper
Results for netherite

It makes sense that Engineer's Goggles and Backtanks aren't hidden, but their visibility should match. (And if they can be hidden, even better.)

Reproduction Steps:

  1. Activate the model in Figura
    • Insert vanilla_model.ARMOR:setVisible(false) in /figura/avatars/[Avatar Name]/script.lua.
    • or use this test avatar: Test.zip
  2. Wear some equipment

Expected Behavior:

All equipment is hidden (or not).

Current Behavior:

Completely hidden:

  • Copper Diving Boots
  • Netherite Diving Boots
  • Copper Diving Helmet
  • Netherite Diving Helmet

Partially hidden:

  • Copper Backtank (The chestplate body parts are hidden, but the backtank isn't.)

Not hidden:

  • Netherite Backtank
  • Engineer's Goggles

Game Log

https://mclo.gs/lq7SixK

Debug Information

Client Info
Create:
	Mod Version: 0.5.1j
	Forge Version: 47.1.106
	Minecraft Version: 1.20.1

Graphics:
	Flywheel Version: 0.6.11-13
	Flywheel Backend: INSTANCING
	OpenGL Renderer: NVIDIA GeForce RTX 4070/PCIe/SSE2
	OpenGL Version: 4.6.0 NVIDIA 560.94
	Graphics Mode: options.graphics.fancy

System Information:
	Operating System: Windows 11 (amd64) version 10.0
	Java Version: 17.0.8, Microsoft
	JVM Flags: 3 total; -XX:HeapDumpPath=MojangTricksIntelDriversForPerformance_javaw.exe_minecraft.exe.heapdump -Xms512m -Xmx8192m
	Memory: 1462908288 bytes (1395 MiB) / 3242196992 bytes (3092 MiB) up to 8589934592 bytes (8192 MiB)
	Total Memory: 22356512768 bytes (21312 MiB) / 68553863168 bytes (65351 MiB)
	CPU: 12th Gen Intel(R) Core(TM) i5-12400F @ 2.50 GHz; 6 cores / 12 threads on 1 socket(s)
	Graphics card #0: NVIDIA GeForce RTX 4070 (NVIDIA (0x10de)); 4095.00 MB of VRAM

Other Mods:
	Figura: 0.1.4+1.20.1
	CosmeticArmorReworked: 1.20.1-v1a
Server Info
Create:
	Mod Version: 0.5.1j
	Forge Version: 47.1.106
	Minecraft Version: 1.20.1

System Information:
	Operating System: Windows 11 (amd64) version 10.0
	Java Version: 17.0.8, Microsoft
	JVM Flags: 3 total; -XX:HeapDumpPath=MojangTricksIntelDriversForPerformance_javaw.exe_minecraft.exe.heapdump -Xms512m -Xmx8192m
	Memory: 1462908288 bytes (1395 MiB) / 3242196992 bytes (3092 MiB) up to 8589934592 bytes (8192 MiB)
	Total Memory: 22356512768 bytes (21312 MiB) / 68553863168 bytes (65351 MiB)
	CPU: 12th Gen Intel(R) Core(TM) i5-12400F @ 2.50 GHz; 6 cores / 12 threads on 1 socket(s)
	Graphics card #0: NVIDIA GeForce RTX 4070 (NVIDIA (0x10de)); 4095.00 MB of VRAM

Other Mods:
	Figura: 0.1.4+1.20.1
	CosmeticArmorReworked: 1.20.1-v1a
@argxentakato argxentakato added the type: bug Issue where something isn't working label Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Issue where something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant