Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signal Groups Ignore Dimensions #5783

Open
techno-sam opened this issue Nov 21, 2023 · 1 comment
Open

Signal Groups Ignore Dimensions #5783

techno-sam opened this issue Nov 21, 2023 · 1 comment
Labels
status: fixed in next release Issue will be fixed in the next release type: bug Issue where something isn't working

Comments

@techno-sam
Copy link
Contributor

Describe the Bug

If two track curves in different dimensions occupy the exact same position, and signals are set up in both dimensions, then there will be only one Signal Group, shared between the dimensions, because the two tracks are considered to be intersecting.
This causes a train in one dimension to produce a red signal in the other dimension.

Reproduction Steps

  1. Hollow out a space centered on (0, 0, 0) in the overworld and nether, and place a gold block at (0, 0, 0) in both dimensions.
  2. Place the attached schematic in each dimension, so that the gold block in the schematic is at (0, 0, 0) and the redstone block is at (4, 0, -1).
  3. Move a train onto the overworld track, like in the screenshot:
    overworld_signals
  4. Observe that the nether-side signal also turns red
    nether_signals

Schematic for reproduction (zipped so github accepts it):
demo.zip

Expected Result

The signal groups would be separated per-dimension (I understand inter-dimensional edges with portals have an exception).

Screenshots and Videos

No response

Crash Report or Log

No response

Operating System

Ubuntu 22.04.1

Mod Version

0.5.1f

Minecraft Version

1.19.2

Forge Version

43.3.0

Other Mods

Create was the only mod installed

Additional Context

It appears (after an hour-long debugging session) that when the TrackPropagator/TrackGraph calls com.simibubi.create.content.trains.graph.EdgeData#addIntersection, it does not include any checks that the 'intersecting' edges are actually in the same dimension.

@HB-Stratos originally discovered this bug, and we've been working together to find exact reproduction steps.

@techno-sam techno-sam added the type: bug Issue where something isn't working label Nov 21, 2023
@phit
Copy link

phit commented Dec 30, 2023

also an issue on 1.20 with create-1.20.1-0.5.1.f its actually blocking @simibubi 's train station on our server..

@IThundxr IThundxr assigned IThundxr and unassigned IThundxr Jan 4, 2025
@IThundxr IThundxr added status: confirmed Issue's details are known, it is consistently reproducible, and it needs a fix status: fixed in next release Issue will be fixed in the next release and removed status: confirmed Issue's details are known, it is consistently reproducible, and it needs a fix labels Jan 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: fixed in next release Issue will be fixed in the next release type: bug Issue where something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants