NBTProcessors improperly filters nbt #4844
Labels
status: fixed in next release
Issue will be fixed in the next release
type: bug
Issue where something isn't working
Describe the Bug
In
Create/src/main/java/com/simibubi/create/foundation/utility/NBTProcessors.java
Lines 85 to 98 in 9148270
an item's nbt is filtered for unsafe values then set to null if it is empty, however this can cause issues as ItemStack#removeTagKey() already sets the nbt to null if it is empty, meaning the getTag() check will return null for the copied stack
Reproduction Steps
This was encountered by puffpastri on the discord where they had a schematic with paintings from Joy of Painting in it causing the schematicannon to be unable to read the schematic
Expected Result
Be able to place the schematic
Screenshots and Videos
https://discord.com/channels/620934202875183104/620937113554124801/1111903044150497280
Crash Report or Log
No response
Operating System
Windows 10
Mod Version
0.5.1b
Minecraft Version
1.18.2
Forge Version
40.2.4
Other Mods
No response
Additional Context
No response
The text was updated successfully, but these errors were encountered: