Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Congrats message #30

Open
6 tasks
YuriDevAT opened this issue Oct 21, 2023 · 6 comments
Open
6 tasks

[FEATURE] Congrats message #30

YuriDevAT opened this issue Oct 21, 2023 · 6 comments
Assignees
Labels
⭐ goal: addition Addition of new feature 🔒 staff only Restricted to CC staff members 🧹 status: ticket work required Needs more details before it can be worked on 💬 talk: discussion Open for discussions and feedback

Comments

@YuriDevAT
Copy link
Contributor

YuriDevAT commented Oct 21, 2023

As a user, I would like to receive feedback on my progress.

Acceptance Criteria

A congrats message is displayed/announced if

  • the user has entered all the tags that start with a certain letter
  • the user has entered 50% of all tags
  • the user has entered 100% of all tags
  • there are 3 tags remaining
  • there are 2 tags remaining
  • there is 1 tag remaining
@YuriDevAT YuriDevAT added Hacktoberfest Good issues for Hacktoberfest participants ⭐ goal: addition Addition of new feature 💬 talk: discussion Open for discussions and feedback 🧹 status: ticket work required Needs more details before it can be worked on labels Oct 21, 2023
@YuriDevAT YuriDevAT removed the Hacktoberfest Good issues for Hacktoberfest participants label Oct 21, 2023
@CorinaMurg
Copy link
Owner

I am working on the alphabetical sorting of the list, and one idea is for each group of tags to be a bit on its own. Visually it would be easier to look up the group starting with a certain letter. We could also mark (and let the screen reader announce) the completion of a group. And the ellipsis (...) could indicate that a group is not yet completed.
A very simplistic design to illustrate this (it was done in Excel!):
image

This could take care of letting users know when they completed one group.
We don't need to have the heading with the group's letter, but at least a gap between each group.

And then of course, announce 50% and 100% completion.
We could also add a countdown when there are only 10 or just 3 left to submit.

@YuriDevAT YuriDevAT added the 🔒 staff only Restricted to CC staff members label Oct 29, 2023
@YuriDevAT
Copy link
Contributor Author

Great idea! This makes it easier to follow the progress.

@CorinaMurg
Copy link
Owner

@YuriDevAT
Do you think this is ready to move forward? By this I mean define the issue more clearly and implement it? I think I was waiting for us to have a UI design ready, but now I realize that the JS parts of this issue could be implemented regardless of the design.

@YuriDevAT
Copy link
Contributor Author

Yeah of course. The content of the message can be separated from the design, I would say. This issue is more about deciding how many messages will there be and what they are going say.

@CorinaMurg CorinaMurg changed the title ### SUGGESTED FEATURES: Congrats message [FEATURE] Congrats message Nov 30, 2023
@CorinaMurg CorinaMurg self-assigned this Nov 30, 2023
@CorinaMurg
Copy link
Owner

CorinaMurg commented Dec 29, 2023

@YuriDevAT
Right now we have an ariaMessage that updates with each new added tag, so a screen reader user will hear "23 added" etc.
This changes to a congrats message at 50% and 100% completion.

Do we want this info displayed also on screen? Not sure if it's necessary since we have the progress bar, but it would be more specific than the progress bar, which some users might prefer.
image

image

Not sure what would be best.
Then the other option is to keep it the way it is, and just add the congrats messages, just as we planned with this issue.

@YuriDevAT
Copy link
Contributor Author

YuriDevAT commented Dec 31, 2023

Yes @CorinaMurg , my suggestion would be as I added it into the design, having the progress showing as a number as well.
Progressbar showing current number of added tags.

Depending on the effort it takes, I would have implemented it with my styles PR already. If it takes more, a new issue for this would be the better choice I guess.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⭐ goal: addition Addition of new feature 🔒 staff only Restricted to CC staff members 🧹 status: ticket work required Needs more details before it can be worked on 💬 talk: discussion Open for discussions and feedback
Projects
None yet
Development

No branches or pull requests

2 participants