Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request upgrade y18n version: Synk Failing - Prototype Pollution - High Severity #113

Closed
samuelkavin opened this issue Nov 24, 2020 · 3 comments · Fixed by #154
Closed
Assignees
Milestone

Comments

@samuelkavin
Copy link

Currently, we are having some security warning in synk. It's requesting upgrade y18n version update to 5.0.5 from 4.0.0.

Error message
Prototype Pollution [High Severity][https://snyk.io/vuln/SNYK-JS-Y18N-1021887] in [email protected]
introduced by [email protected] > [email protected] > [email protected] > [email protected]

This issue was fixed in versions: 5.0.5

@Cordobo
Copy link
Owner

Cordobo commented Jan 19, 2021

@Cordobo Cordobo self-assigned this Jan 19, 2021
@Cordobo
Copy link
Owner

Cordobo commented Jan 19, 2021

Hi @samuelkavin

thanks for opening this issue. I will update the lib when an updated version of the underlying lib becomes available.

@Cordobo Cordobo added this to the 13.1.0 milestone Jan 11, 2022
@Cordobo
Copy link
Owner

Cordobo commented Jan 12, 2022

It appears as the author of the original qrcode dependency currently has no time to merge the open PR mentioned above. For now, I forked [1] the lib and bumped the dependency to a fixed version [2].

In partial this was because of an issue with the lib colors.js, used by qrcode.

The moment the open PR gets merged into the qrcode lib, the dependency will be switched back.

[1] The used fork is located here:
https://github.com/Cordobo/node-qrcode

[2] Commit
Cordobo/node-qrcode@e09bcd3

[3] colors.js
soldair/node-qrcode#294

Cordobo added a commit that referenced this issue Jan 12, 2022
@Cordobo Cordobo linked a pull request Jan 12, 2022 that will close this issue
Cordobo added a commit that referenced this issue Jan 12, 2022
@Cordobo Cordobo linked a pull request Jan 12, 2022 that will close this issue
@Cordobo Cordobo closed this as completed Jan 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants