Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hard dependency on libTIFF ? #30

Open
sbastrakov opened this issue Mar 20, 2019 · 1 comment
Open

Remove hard dependency on libTIFF ? #30

sbastrakov opened this issue Mar 20, 2019 · 1 comment

Comments

@sbastrakov
Copy link
Member

I think these bindings are good to have, but should not be mandatory. I suggest making a new CMake option of whether to use libTIFF, like how we do in other projects, and enable the dependency and these pieces of code conditionally.

@Flamefire
Copy link
Contributor

The best approach is to split the code into the library and examples (all in different folders). See https://api.csswg.org/bikeshed/?force=1&url=https://raw.githubusercontent.com/vector-of-bool/pitchfork/develop/data/spec.bs for a great way to structure a project.

The examples should be disabled by default but enabled for CI via CMake

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants