Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compile errors due to c++14_types.hpp #27

Open
sbastrakov opened this issue Mar 12, 2019 · 1 comment
Open

Compile errors due to c++14_types.hpp #27

sbastrakov opened this issue Mar 12, 2019 · 1 comment

Comments

@sbastrakov
Copy link
Member

Creating an issue just to document the behaviour discovered at hackathon with @sk1p .

With current compilers this file causes compile errors. And the way it tries to extend namespace std is technically incorrect. It seems the solution can be to just remove this file, replace its includes with <type_traits> and raise C++ standard requirements to C++14 (C++11 is mostly enough, but there is stuff like std::result_of_t that are 14).

@Flamefire
Copy link
Contributor

Correct. If wanted the code can be wrapped in a conditional #if not C++14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants