Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TextBoxExtensions sample in gallery crashes under Windows App SDK #510

Open
1 of 24 tasks
Arlodotexe opened this issue Sep 18, 2024 · 3 comments
Open
1 of 24 tasks
Assignees
Labels
bug Something isn't working regression What was working is now broke sample app 🖼️

Comments

@Arlodotexe
Copy link
Member

Arlodotexe commented Sep 18, 2024

Describe the bug

Under the latest main commit, opening the TextBoxExtensions sample will cause the gallery app to crash.
image

   at WinRT.ExceptionHelpers.<ThrowExceptionForHR>g__Throw|38_0(Int32 hr)
   at ABI.Windows.UI.Input.IRadialControllerStaticsMethods.CreateForCurrentView(IObjectReference _obj)
   at Windows.UI.Input.RadialController.CreateForCurrentView()
   at CommunityToolkit.WinUI.TextBoxExtensions.OnSurfaceDialOptionsPropertyChanged(DependencyObject d, DependencyPropertyChangedEventArgs e) in /_/components/Extensions/src/Text/TextBoxExtensions.SurfaceDial.cs:line 138
   at ABI.Microsoft.UI.Xaml.PropertyChangedCallback.Do_Abi_Invoke(IntPtr thisPtr, IntPtr d, IntPtr e)

This behavior is not present when running the gallery under UWP.

Steps to reproduce

1. Clone the repo
2. Generate the gallery solution, include the Extensions component and the wasdk multitarget/head.
3. Build and deploy the wasdk gallery 
4. Navigate to the TextBoxExtensions sample page and observe crash.

Expected behavior

No crash

Screenshots

No response

Code Platform

  • UWP
  • WinAppSDK / WinUI 3
  • Web Assembly (WASM)
  • Android
  • iOS
  • MacOS
  • Linux / GTK

Windows Build Number

  • Windows 10 1809 (Build 17763)
  • Windows 10 1903 (Build 18362)
  • Windows 10 1909 (Build 18363)
  • Windows 10 2004 (Build 19041)
  • Windows 10 20H2 (Build 19042)
  • Windows 10 21H1 (Build 19043)
  • Windows 10 21H2 (Build 19044)
  • Windows 10 22H2 (Build 19045)
  • Windows 11 21H2 (Build 22000)
  • Other (specify)

Other Windows Build number

No response

App minimum and target SDK version

  • Windows 10, version 1809 (Build 17763)
  • Windows 10, version 1903 (Build 18362)
  • Windows 10, version 1909 (Build 18363)
  • Windows 10, version 2004 (Build 19041)
  • Windows 10, version 2104 (Build 20348)
  • Windows 11, version 22H2 (Build 22000)
  • Other (specify)

Other SDK version

No response

Visual Studio Version

No response

Visual Studio Build Number

No response

Device form factor

No response

Additional context

No response

Help us help you

Yes, I'd like to be assigned to work on this item.

@Arlodotexe
Copy link
Member Author

This error will throw even after disabling AoT, suggesting it might be a regression that happened between Microsoft.WindowsAppSdk 1.5 and 1.6.

@Arlodotexe Arlodotexe self-assigned this Oct 10, 2024
@Arlodotexe
Copy link
Member Author

Arlodotexe commented Nov 4, 2024

The source of the issue here seems to be that RadialController.CreateForCurrentView is being called from a non-UI thread, despite being invoked by a dependency property as a PropertyChangedCallback delegate.

private static void OnSurfaceDialOptionsPropertyChanged(DependencyObject d, DependencyPropertyChangedEventArgs e)
{
if (!IsSurfaceDialOptionsSupported)
{
return;
}
if (d is not TextBox textBox)
{
return;
}
// Initialize our RadialController once.
_controller ??= RadialController.CreateForCurrentView();
textBox.GotFocus -= TextBox_GotFocus_SurfaceDial;
textBox.LostFocus -= TextBox_LostFocus_SurfaceDial;
if (e.NewValue is not null)
{
textBox.GotFocus += TextBox_GotFocus_SurfaceDial;
textBox.LostFocus += TextBox_LostFocus_SurfaceDial;
}
}

This behavior isn't present in UWP or WindowsAppSdk 1.5 and doesn't seem to be related to the recent AoT changes in 1.6.

This definitely seems like a regression that occurred between 1.5 and 1.6, will need to gather more information to decide whether to file an issue with the platform.

@Sergio0694
Copy link
Member

"Windows.UI.Input.RadialController.CreateForCurrentView()"

That doesn't sound like it should work on WASDK at all. WinUI 3 apps have no "current view" (that's a UWP concept).
Are you sure that same code was actually running and working before, on WASDK?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working regression What was working is now broke sample app 🖼️
Projects
Status: 🏗 In progress
Development

No branches or pull requests

2 participants