Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exclude-selectors does not work #692

Open
JiYouMCC opened this issue Aug 29, 2024 · 1 comment
Open

exclude-selectors does not work #692

JiYouMCC opened this issue Aug 29, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@JiYouMCC
Copy link

I tried to exclude the emoji image such as below while indexing(in order to ignore them when creating meta):

<img class="emoji" title=":+1:" alt=":+1:" src="https://github.githubassets.com/images/icons/emoji/unicode/1f44d.png" height="20" width="20">

(the img with class=emoji)

But the option seems no work.

My command as below:
./pagefind_extended --site ${{ github.workspace }}/_site --exclude-selectors "img.emoji" --glob blog/post/**/*.html
https://github.com/JiYouMCC/JiYouMCC.github.io/blob/master/.github/workflows/build_jekyll_with_pagefind.yml#L33

Did I misunderstand the documentation or made some mistake?

@bglw
Copy link
Contributor

bglw commented Aug 30, 2024

Hey @JiYouMCC 👋

Thanks for the report — this looks like something that should be improved. That flag is currently marking the node as "ignored" (the same as data-pagefind-ignore) which removes it from the index, but still allows metadata to be discovered. It should instead be marking the node as "excluded", the same as data-pagefind-ignore="all", which also blocks the metadata.

Will fix 👍

@bglw bglw added the bug Something isn't working label Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants