Implicit rain fall always #3515
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll start the |
trontrytel
force-pushed
the
aj/issue_3511
branch
from
47fdbfb to
75b0e5a
Compare
szy21
approved these changes
Jan 6, 2025
trontrytel
force-pushed
the
aj/issue_3511
branch
3 times, most recently
from
3133708 to
67da7d6
Compare
dennisYatunin
approved these changes
Jan 13, 2025
Comment on lines
231
to
234
| MatrixFields.unrolled_map( | ||
| name -> (name, @name(c.ρ)) => similar(Y.c, TridiagonalRow), | ||
| available_tracer_names_precip, | ||
| )..., |
There was a problem hiding this comment.
Instead of initializing these blocks and setting them to 0, let's just remove them altogether.
| dtγ * -(ᶜprecipdivᵥ_matrix()) ⋅ | ||
| DiagonalMatrixRow(Geometry.WVector(1) * ᶠwinterp(ᶜJ, ᶜρ)) ⋅ | ||
| ᶠright_bias_matrix() ⋅ DiagonalMatrixRow(-(ᶜwₚ) / ᶜρ) - (I,) | ||
| ∂ᶜρqₚ_err_∂ᶜρ .= (zero(eltype(∂ᶜρqₚ_err_∂ᶜρ)),) |
There was a problem hiding this comment.
Since we're not planning to add these blocks later, we can just get rid of this. Hopefully it doesn't change anything.
trontrytel
force-pushed
the
aj/issue_3511
branch
from
67da7d6 to
cf03bf9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #3511