Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save revisions for product records #217

Open
ghost opened this issue Feb 18, 2020 · 5 comments
Open

Save revisions for product records #217

ghost opened this issue Feb 18, 2020 · 5 comments
Labels
Feature Request New feature that users would like in the project.
Milestone

Comments

@ghost
Copy link

ghost commented Feb 18, 2020

Is your feature request related to a problem? Please describe.
If I need to revert a change to a product record there are no revisions saved.

Describe the solution you'd like
CC would save revisions, the same as CP.

Additional context
By default, WooCommerce does not work with WordPress revisions. You need to add some code to the functions.php file in your theme to get revisions to work. Classic Commerce is the same with CP.

It is not necessary to save unlimited revisions. Maybe three would be a good number to set as a default number.

@nylen
Copy link
Contributor

nylen commented Feb 18, 2020

I don't think this should be enabled by default in v1. It's going to be an unexpected behavior for anyone switching from Woo, and it's not impossible that this could break something, whether an extension that doesn't support this behavior or a workflow (for example, someone edits a product that contained sensitive info, and expects all sensitive info to be expunged from the database as a result).

If this is desired to be supported for CC v1, a setting could be added to enable revisions for products, and the setting should be disabled by default.

I probably wouldn't bother with limiting the number of revisions either, unless we find that it is common for people to automatically update product records every day or something. Storing lots of revisions shouldn't have a performance impact since the data is well-indexed, and revisions take up a tiny amount of DB space compared to things like normal orders coming through a store.

@nylen nylen changed the title Save revisions Save revisions for product records Feb 18, 2020
@timbocode
Copy link
Contributor

I think this is a good idea and I don't see why it's not enabled by default for WC but I agree it's not something for v1. I definitely don't want to introduce any potentially breaking changes just as we're approaching the first beta release. Maybe v1.1?

Also agree it should be a core CC setting rather than a snippet to be added to functions.php.

@ghost
Copy link
Author

ghost commented Feb 19, 2020

Yes, agree with all that. No urgency on this and can easily be included in a later version. And it could certainly be a setting that is disabled by default.

@bahiirwa
Copy link
Collaborator

bahiirwa commented Aug 8, 2020

@timbocode Is this for tagging as feature request?

@timbocode timbocode added the Feature Request New feature that users would like in the project. label Aug 8, 2020
@timbocode
Copy link
Contributor

Yes, now tagged as feature request.

@striebwj striebwj added this to the Version 2.0.0 milestone Jul 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Request New feature that users would like in the project.
Projects
None yet
Development

No branches or pull requests

4 participants