Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Math confusion in the report, redo layout #23

Open
mgifford opened this issue Jun 27, 2023 · 2 comments
Open

Math confusion in the report, redo layout #23

mgifford opened this issue Jun 27, 2023 · 2 comments
Assignees

Comments

@mgifford
Copy link
Collaborator

Daniel, I'm hoping you can look into this.

As you can see here https://github.com/CivicActions/openacr/blob/295e763d145cbad72fb89e6085aed5a4c37822b4/openacr/drupal-10-16.html#L335C18-L335C18

The math doesn't add up:

Conformance to the 30 criteria listed below is distributed as follows:
• 32 supported
• 20 partially supported
• 0 not supported
• 68 not applicable

I'm not exactly sure why, but is something that should be resolved.

@dmundra
Copy link
Collaborator

dmundra commented Jun 27, 2023

@mgifford I am not sure why the math is not adding up. I check it manually and also used yq to do the math with the yaml file and I am getting the same numbers as the table.

@dmundra
Copy link
Collaborator

dmundra commented Jun 27, 2023

Ah, the math is not wrong but the display is confusing. From @maggiewachs, the total is actually 30x4 (4 types of levels for each criteria). Solution is to instead display the numbers as table with rows being the level and columns the different types (Web, Electronic Documents, Software, Authoring Tool).

Potential table display:
Screenshot of table from PDF

@dmundra dmundra changed the title Math problems in the report Math confusion in the report, redo layout Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants