-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update and rename ux-designer.md to designer.md #783
Conversation
@dmundra I'd like to remove all of the accordions and add this content onto the page. I'm not seeing where the accordions are controlled though?
for more information, see https://pre-commit.ci
Pa11y testing results
|
1 similar comment
Pa11y testing results
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@thejordanwood the accordions are generated dynamically. I am not sure how this new page will look but lets preview it. You can do that by adding the label 'qa-pull-request' to this pull request. Once that job finishes it will provide a comment with a URL to the QA site.
You can test changes in this branch at https://accessibility-qa.civicactions.com/. If you pushed additional changes and need to reapply them, remove and readd the label 'qa-pull-request'. The QA repo can be accessed at https://github.com/CivicActions/accessibility-qa. |
@dmundra I have managed to 404 the original ux designer page and the new designer page shows no content at all, so I guess that wasn't the way to do things. What would be a better way to handle this? |
Ya I figured that might happen. I think I can figure out how to get your page going but it will take me a little bit to investigate. Can we leave this up while I try that? |
@dmundra Yep! There's no rush on this, so take your time. Thanks for looking into it. |
Pa11y testing results
|
… pages. Updated designer page to use new layout and redirect the old page. Updated roles landing page.
Pa11y testing results
|
@thejordanwood so I was to able to make your role page act like a guide page by adding the following:
|
You can test changes in this branch at https://accessibility-qa.civicactions.com/. If you pushed additional changes and need to reapply them, remove and readd the label 'qa-pull-request'. The QA repo can be accessed at https://github.com/CivicActions/accessibility-qa. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@thejordanwood review the page now https://accessibility-qa.civicactions.com/roles/designer. How is that looking?
@laflannery since I added a bunch of changes can you review this PR or @maggiewachs? Let me know if you have any questions. |
@thejordanwood was the intention to remove and redirect the Content Designer page to this new one? I ask because it's mentioned in the new content that "Content Designer" is another name for "UX Designer" |
@dmundra Thanks for figuring that out! The page looks great to me. Can we also get rid of the Content Designer page and redirect to the Designer page? The UX and Content designer pages are being combined into this one. cc: @laflannery |
@thejordanwood yes I can do that. |
Pa11y testing results
|
Pa11y testing results
|
You can test changes in this branch at https://accessibility-qa.civicactions.com/. If you pushed additional changes and need to reapply them, remove and readd the label 'qa-pull-request'. The QA repo can be accessed at https://github.com/CivicActions/accessibility-qa. |
Thanks @laflannery. @thejordanwood please go ahead and click the 'Squash and merge' button. |
@dmundra I'd like to remove all of the accordions and add this content onto the page. This is how we want to structure the roles pages moving forward. I'm not seeing where the accordions are controlled though?