Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dashboard - Date Range Selection #89

Open
4 of 5 tasks
aharpalaniTO opened this issue Nov 21, 2017 · 11 comments
Open
4 of 5 tasks

Dashboard - Date Range Selection #89

aharpalaniTO opened this issue Nov 21, 2017 · 11 comments
Assignees
@radumas
Milestone
Internal Dashboar...

Comments

@aharpalaniTO
Copy link

aharpalaniTO commented Nov 21, 2017 •
edited by radumas
Loading

Add functionality for date range selection with following options:

  • Last Day
  • Select Day
  • Last Week
  • Last Month
  • Total "After" Period
@radumas radumas added this to the Internal Dashboard v2 milestone Nov 22, 2017
@radumas
Copy link
Member

radumas commented Nov 22, 2017

The preferred method for tackling this is a dropdown which would also highlight which days would be included in the averages yeah?

@radumas radumas mentioned this issue Nov 30, 2017
Open
@radumas radumas self-assigned this Dec 6, 2017
@radumas
Copy link
Member

radumas commented Dec 6, 2017

Working on Selecting a Day at the moment.

Something to implement after is changing min_date_allowed & max_date_allowed based on the selected day_type and timeperiod

@radumas
Copy link
Member

radumas commented Dec 6, 2017 •
edited
Loading

Interesting bit of interaction trouble implementing the DatePickerSingle: One can only restrict the min and max dates that can be selected. There's no way to, for example, restrict weekend days. So someone can select 'Weekend' and then a weekday, and the data for the table will be completely filtered. This also applies to the timeperiod filter.

Possible solutions:

  1. Restrict the day_type filter to not apply to table data if selecting a single day and the day_type value would get updated by the selected day and consequently update the graphs. Table filtering would have to autodetect the day_type to select the appropriate baseline. Timeperiod would behave the same: update the selections to the appropriate day_type for the selected date. day_type selection would update the date to the next available of that day_type
  2. Trigger a pop-up and don't change anything. This is actually non-trivial to implement since all callback functions are stateless, the Python doesn't know the previous state of the front-end

@radumas
Copy link
Member

radumas commented Dec 6, 2017 •
edited
Loading

It's also feasible to disable some radio button options in date selection mode,

radumas added a commit that referenced this issue Dec 7, 2017
@radumas
#89 Add Week selector
b4d2a9e 
Gets unique weeks from dash_daily.
Detect date_range_type dropdown change and display week selector
dropdown
@radumas
Copy link
Member

radumas commented Dec 8, 2017

Working on Week Selector: Updating table to reflect average of selected week

radumas added a commit that referenced this issue Dec 8, 2017
@radumas
Work on #89, weekly averages in table
a817af0 
Still need to highlight colour in plot
radumas added a commit that referenced this issue Dec 10, 2017
@radumas
Implement Week selector #89
7da6b64 
also fix #63 again
@radumas
Copy link
Member

radumas commented Dec 11, 2017

Working on Months now.

radumas added a commit that referenced this issue Dec 11, 2017
@radumas
Add views for weeks and months #89
6fbf257
radumas added a commit that referenced this issue Dec 11, 2017
@radumas
Added Month selector
b76b9e7 
#89
Entire main-div doesn't seem to be displaying
radumas added a commit that referenced this issue Dec 11, 2017
@radumas
Fix display error in #89
ad27da0 
options=None led to entire STREETS_LAYOUT not displaying.
@radumas
Copy link
Member

radumas commented Dec 12, 2017

Re Selecting a date
plotly/dash-core-components#126

@radumas
Copy link
Member

radumas commented Dec 12, 2017 •
edited
Loading

I think I'll just try implementing an exception check in the date picker callback, to prevent further updates (see this) and figure out what to do from there: implement an improved DatePicker or something more complicated on our side.

radumas added a commit that referenced this issue Dec 14, 2017
@radumas
Add DatePicker #89
11abf83 
Update issue for Last Day, graphs & table
radumas referenced this issue Dec 20, 2017
@radumas
Merge branch 'datepicker' into internal_dash_v3
734df36
@radumas
Copy link
Member

radumas commented Dec 20, 2017 •
edited
Loading

Outstanding for date_picker:

  • Hide Weekend-Weekday Selection
  • Update Weekend-Weekday day type based on selected date
  • Update graph date ranges.

radumas added a commit that referenced this issue Dec 23, 2017
@radumas
Update day_type from selected date #89
1210fc2 
Hide day_type buttons when Selecting Dates
radumas added a commit that referenced this issue Dec 23, 2017
@radumas
Filter data to make plot look better #89
4fb02ff 
Further refine filtering #89

Remove specifying graph date range at declaration, since already filtering data
radumas added a commit that referenced this issue Dec 23, 2017
@radumas
Improve month display #89
9bb5ce2 
Have Select Month show last month of data when selected Month is latest month
@radumas
Copy link
Member

radumas commented Jan 1, 2018

What to do about selecting a date for which there aren't later timeperiods available for that date (only really applicable for most recent date)?

Currently silently fails to update the table. Not ideal
Can filter available timeperiods by date selected and vice-versa: available dates by selected timeperiod

radumas referenced this issue Jan 1, 2018
@radumas
Bugfix: graph display with selecting most recent time period
075508f 
For selecting date, week, or month.
radumas referenced this issue Jan 1, 2018
@radumas
Bugfix with undeclared date_picked for Last Day
57333d9
radumas added a commit that referenced this issue Jan 4, 2018
@radumas
#89 Update timeperiods when selecting date
7b6dc1a
radumas added a commit that referenced this issue Jan 10, 2018
@radumas
#89 Exclude Excluded dates from table average
8b45c89
@radumas
Copy link
Member

radumas commented Jan 10, 2018

Excluded dates are currently blank on the charts, should they be Ghost Bars?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@radumas radumas

Labels
None yet
Projects
None yet
Milestone
Internal Dashboard v3
Development

No branches or pull requests
2 participants
@radumas @aharpalaniTO