You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
function hubTransfer(
address from, address to, uint256 amount
) public onlyHub returns (bool) {
_transfer(from, to, amount);
}
I guess this is some remnant from some old code, the _transfer function does not return an outcome. And the only place this is called is in the Hub.transferThrough function, where its outcome is not inspected.
I have not investigated further, whether the success of each transfer is validated somehow, though the validateTransferThough suggests it should be.
The text was updated successfully, but these errors were encountered:
We are attempting at "verifying" the contract with Solidity's SMTChecker, which already found the following.
In https://github.com/CirclesUBI/circles-contracts/blob/master/contracts/Token.sol#L170-L172 the
hubTransfer
function always returns false:I guess this is some remnant from some old code, the
_transfer
function does not return an outcome. And the only place this is called is in theHub.transferThrough
function, where its outcome is not inspected.I have not investigated further, whether the success of each transfer is validated somehow, though the
validateTransferThough
suggests it should be.The text was updated successfully, but these errors were encountered: