Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabling Custom Styles in the Customizer is not changing colors in the latest version 1.3.6 #136

Open
1 task done
angela-crist opened this issue Jul 13, 2016 · 20 comments

Comments

@angela-crist
Copy link

Issue Type

Steps to Reproduce

I tested by setting up a locate with the latest version 1.3.6 by following these steps:

  • Download version 1.3.6
  • Go to Appearance > Customize > Colors
  • Enable Custom Styles and try pre-defined schemes and my own colors
  • They don't change the site colors in the customizer preview or once you save

I also tested our http://demo.churchthemes.net/uplifted/ which is currently running on vesion 1.3.45

  • It works with this version.

Plugins

  • I asked one of the customers to deactivate all of their plugins (when I didn't notice that the demo was not the most recent version) Plugins were not interfering in that case.

Versions

Wordpress: 4.5.3
Uplifted: 1.3.6

Relevant Error Log

[Sun Jul 10 12:01:30 2016] [error] [client 68.50.51.9] File does not exist: /home6/joshfuhs/public_html/flc-demo/wp-content/uploads/2016/07/colors.scss, referer: http://flc-demo.joshfuhs.com/wp-content/uploads/2016/07/colors.css?ver=2016-07-10

[Sun Jul 10 12:01:31 2016] [error] [client 68.50.51.9] File does not exist:
/home6/joshfuhs/public_html/flc-demo/colors.scss, referer: http://flc-demo.joshfuhs.com/wp-admin/customize.php?return=%2Fwp-admin%2Ftheme-editor.php%3Ffile%3Dstyle.css%26theme%3Duplifted-churchthemes-1.3.6

One of the customers when asked for admin access said:

You can tell me what you'd like me to look for. I'm fairly familiar with Linux systems, so I can probably track down what you want.

Is color selection a feature of WordPress or a feature of Uplifted?

@christianc1
Copy link
Member

@angela-crist I can probably get to this tomorrow afternoon around 3:30p and can spend max an hour on it.

@angela-crist
Copy link
Author

Awesome thanks @christianc1 Let me know if I need to do anything to prep for you prior to that time. I want to make sure everything that I can do is ready for you to just jump in.

@christianc1
Copy link
Member

Works fine for me @v1.3.6 http://lift.d.pr/1aqga/KEgyujlU

@angela-crist
Copy link
Author

It's so weird it works for me on the demo but not on a fresh install.

@christianc1
Copy link
Member

I think we're getting inconsistent results here possibly due to php memory limit. The PHP file that reads the customizer values, compiles sass to css, then writes the css to the server is a fairly resource intensive process. Low PHP Memory limits may be causing this issue for some but wouldn't affect users with a higher limit. Just a hypothesis at this point.

@angela-crist
Copy link
Author

Hmmm so I could tell the customer to reach out to their host and increase the PHP memory limit? @christianc1

@angela-crist
Copy link
Author

Looked my up memory limit and it was fine so back to the drawing board as to why it's working fine on demo but not on a fresh install on my local.

@angela-crist
Copy link
Author

Here's what I did to reproduce this issue:

  1. Installed version 1.3.6 of Uplifted on a fresh install locally with the latest version of WordPress
  2. Go into the Customizer to Colors
  3. Select Yes for Enable Custom Styles

I get this: http://lift.d.pr/151OJ/DHrm1KOA

@garand @chriswallace Do you get a different result in with a fresh install?

@chriswallace
Copy link

@angela-crist how are you installing Uplifted? Where are you getting the theme zip from?

@angela-crist
Copy link
Author

@chriswallace I'm getting the file from the ChurchThemes.net Downloads - thinking this is what the customer gets. Then installing that on my local setup.

Let me know what the next steps may be in solving this. Were you able to reproduce the issue using the steps above?

@angela-crist
Copy link
Author

We have another customer that is having this issue. This customer just upgraded to the latest version where customizing his colors were working previously and now it doesn't work. https://secure.helpscout.net/conversation/208385605/10026/?folderId=272858

I've been able to reproduce however @chriswallace I know you have not, so I'm not sure what is with my local setup that is common with the customers.

Any troubleshooting advice or next steps are greatly appreciated!

@angela-crist
Copy link
Author

I still see this issue when I upload a new zip file for the 1.3.6 version (current version) on my local.
But when I test on http://demo.churchthemes.net/ with the same version. I don't see this issue.

Can you someone help me to see if there is any issue?
The users saw what I saw on my local. I haven't reached out to those customers I'd love to get a since if there is an error before I reach out again.

@mrpritchett
Copy link
Contributor

Can you and I walk through this one together @angela-crist so I can make sure I'm seeing EXACTLY what is the issue?

@angela-crist
Copy link
Author

Sure @mrpritchett basically when using the customizer the selecting colors does not work and it stays the same colors. Where you not able to reproduce this? We can test together on Monday if you want.

@mrpritchett
Copy link
Contributor

@angela-crist Please download the latest from uplifted's repo and test. IF approved, I'll update the plugin and release a new version.

@angela-crist
Copy link
Author

angela-crist commented Jan 26, 2017

@mrpritchett I know this is super dusty but trying to attempt to test this.
This is not a priority but could you help me I tried to activate the theme after downloading from the repo and I get these errors: http://lift.d.pr/V3YU/42JuBqJA

Can you tell me what I to do next to make sure I don't get this error. Thank you!

@angela-crist
Copy link
Author

@mrpritchett
Copy link
Contributor

My local seems to be working. Do you have the framework installed @angela-crist ???

@angela-crist
Copy link
Author

Probably not. I just used a script Anthony wrote for me years ago to set up a WordPress site on my local and then tried to upload the new theme version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants