From 37a164e4ce84ca5acf9312e80c99d1ffc4c61450 Mon Sep 17 00:00:00 2001 From: jatin Date: Tue, 9 Apr 2024 01:29:32 -0700 Subject: [PATCH] Ci fixes --- .../Allocators/chowdsp_STLArenaAllocator.h | 5 +++-- .../common/chowdsp_logging/Loggers/chowdsp_FormatHelpers.h | 2 +- modules/common/chowdsp_logging/chowdsp_logging.h | 1 - 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/modules/common/chowdsp_data_structures/Allocators/chowdsp_STLArenaAllocator.h b/modules/common/chowdsp_data_structures/Allocators/chowdsp_STLArenaAllocator.h index fa0a6adae..b41cef897 100644 --- a/modules/common/chowdsp_data_structures/Allocators/chowdsp_STLArenaAllocator.h +++ b/modules/common/chowdsp_data_structures/Allocators/chowdsp_STLArenaAllocator.h @@ -15,7 +15,8 @@ struct STLArenaAllocator } template - STLArenaAllocator (const STLArenaAllocator& other) noexcept : arena (other.arena) // NOLINT + explicit STLArenaAllocator (const STLArenaAllocator& other) noexcept + : arena (other.arena) { } @@ -30,7 +31,7 @@ struct STLArenaAllocator return static_cast (arena.allocate_bytes (n, alignof (T))); } - void deallocate (T*, std::size_t) + void deallocate (T*, std::size_t) const { // no-op... // memory will be re-claimed when the arena is cleared. diff --git a/modules/common/chowdsp_logging/Loggers/chowdsp_FormatHelpers.h b/modules/common/chowdsp_logging/Loggers/chowdsp_FormatHelpers.h index d7985dbd3..ad7bfd6a7 100644 --- a/modules/common/chowdsp_logging/Loggers/chowdsp_FormatHelpers.h +++ b/modules/common/chowdsp_logging/Loggers/chowdsp_FormatHelpers.h @@ -28,7 +28,7 @@ std::string_view vformat (ArenaType& arena, fmt::string_view format_str, fmt::fo { using FormatAllocator = STLArenaAllocator; FormatAllocator alloc { arena }; - fmt::basic_memory_buffer buffer { alloc }; + fmt::basic_memory_buffer buffer { alloc }; fmt::vformat_to (std::back_inserter (buffer), format_str, args); return { buffer.data(), buffer.size() }; } diff --git a/modules/common/chowdsp_logging/chowdsp_logging.h b/modules/common/chowdsp_logging/chowdsp_logging.h index 2587d3c00..e4e0d2f6c 100644 --- a/modules/common/chowdsp_logging/chowdsp_logging.h +++ b/modules/common/chowdsp_logging/chowdsp_logging.h @@ -27,7 +27,6 @@ BEGIN_JUCE_MODULE_DECLARATION JUCE_BEGIN_IGNORE_WARNINGS_GCC_LIKE ("-Wswitch-enum", "-Wfloat-equal", "-Wextra-semi", - "-Wzero-length-array", "-Wc++20-compat", "-Wlanguage-extension-token")