Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebalance mesh on receipt of peer subscriptions? #235

Open
achingbrain opened this issue Apr 26, 2022 · 2 comments
Open

Rebalance mesh on receipt of peer subscriptions? #235

achingbrain opened this issue Apr 26, 2022 · 2 comments

Comments

@achingbrain
Copy link
Collaborator

When the subscriptions of a peer are sent, we add them to the subscribers for a given topic, but we have to wait for the heartbeat before they (might) get added to the mesh for the topic, so there's a brief window during which we know a peer is interested in a topic, but we won't gossip any messages on that topic to them.

I'm not sure why it's like this, we could rebalance the mesh when we are informed of their subscriptions and before emitting the subscription-change event, then arbitrary delays in tests like this would not be necessary which makes everything a lot less flaky.

@dapplion
Copy link
Contributor

@achingbrain That's a good point! Shouldn't be expensive to do

@stale
Copy link

stale bot commented Jun 12, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants