Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize mesh-data hashing for instancing #31

Open
corybarr opened this issue Jul 24, 2024 · 0 comments
Open

Optimize mesh-data hashing for instancing #31

corybarr opened this issue Jul 24, 2024 · 0 comments

Comments

@corybarr
Copy link
Contributor

When profiled on Snowden, the Revit addin currently spends 57% of its time hashing mesh data to check for instances. Most of this 57% is in the serialization of the mesh data prior to calculating the hash. This can be optimized.

A simple optimization would be to initially check for the same number of vertices prior to expensive serialization. Other quick tests such as normalized bounding-box ratios might be possible.

It might also be possible to skip mesh-data hashing altogether. The System property of a FamilyInstance looks similar to a shared mesh across instances:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant