Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug in protobuf feature build for Windows #22

Open
williballenthin opened this issue Oct 30, 2024 · 0 comments
Open

bug in protobuf feature build for Windows #22

williballenthin opened this issue Oct 30, 2024 · 0 comments

Comments

@williballenthin
Copy link

#14 introduces support for building the protobuf code on Windows, but I think its subtly broken: using target_os in build.rs reflects the OS of the host building the build script, not the final program. ref

So, this code should be updated: https://github.com/CerebusOSS/ella/blob/0343b4f54f1f81d093a27da79192ed9c468fffec/ella-server/build.rs#L2C1-L5C66

perhaps to if std::env::var_os(key: "CARGO_CFG_WINDOWS").is_some() {...} else {...}

I encountered this while trying to get my project to build prost/protobuf-src for Windows, and your work got me nearly the whole way there. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant