Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run rustfmt and clippy? #104

Open
stevefan1999-personal opened this issue Nov 10, 2024 · 1 comment
Open

Run rustfmt and clippy? #104

stevefan1999-personal opened this issue Nov 10, 2024 · 1 comment

Comments

@stevefan1999-personal
Copy link

I find it weird why rustfmt and clippy wasn't run for a long time considering that they make code contribution consistent and close to the standard. Can we at least have those once for a while?

@CensoredUsername
Copy link
Owner

Hi!

This has been mostly a just me shop for a while, and as such I've never really found much of a reason for doing this. Rustfmt also isn't perfect and tends to produce some really ugly code in places sadly, so such a run will need some manual work to figure out what rustfmt tends to mess up, which I haven't really had the time / motivation for.

That said, I'm open to someone doing this, but it should preferably be on parts of the project per pull request, and with manual review to figure out where rustfmt suddenly blew up a definitions enum specifically formatted to make it easy to understand to 128 lines of code :/.

I've marked some of my comments in this pull request in the past already in #76

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants