-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature Request]: Quick class method to get cluster count and cluster composition #436
Comments
Hi Bin, If you do For your second point, we do not have this feature yet. To get the relationship between bit_combos and a species (only in indicator basis) I think the best option right now is to print out a site space: |
Thanks Ronald. |
Thanks for clarifying, I think I understand your question better now. So you want to multiply a value of your correlation vector in the feature matrix by a certain value (N) to obtain a concentration, and you are trying to obtain N?
Your code as written would only multiply the matrix element by the orbit multiplicity. However the composition of a cluster decoration may be degenerate by value len(arr), so you should multiply by that degeneracy as well. |
Actually thinking about it again, @Jeff-oakley I think you were right the first time. That extra multiplicity I mentioned shows up in the orbit but not in the correlation function, I believe. |
Hi @Jeff-oakley and @kamronald, Obtaining the correlation function multiplicities should be implemented in the As you mention, the only way to obtain the total number of specific cluster occupations (such as your example Mn-Mn dimers) right now is to use a cs with an indicator basis (assuming the occupation you want is included). To do so, you simply need to add the For the case of other basis functions, I have code that is not fully tested to obtain the transformation matrix needed to compute cluster counts from correlation vectors, but I have not had the time to clean it up and fully test it. However I would be happy to push it to a dev branch in case you are interested. |
Thanks Ronald the Luis! I will look into that. The indicator basis should be good enough for now but it would be great to have the cluster count for other basis as well:) |
Hi Luis - I tried what you recommended. However I obtain fractional amount of clusters. Why we have 0.08333333333333333 number of cluster? Or maybe the cluster counting is not correct? I prepared one example as attached below |
Email (Optional)
[email protected]
Problem
Can we have some class method to get cluster count (under indicator basis) and cluster composition more easily? Or can I double check if the code below is correct to get how many clusters we have?
Proposed Solution
Add two class method? For the cluster count, maybe just use my code above or the corrected version if my code is not correct.
For the cluster composition, need a bit work on mapping bit_combos into a string? Is there a class attribute to map the indices in bit_combos into certain specie?
Alternatives
No response
Code of Conduct
The text was updated successfully, but these errors were encountered: