-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feedback #3
Comments
The issue in itself is a valued contribution @matejkramny. ng2-skel is by no means complete or even stable. I need your help. Debate is good. Let's discuss these. What do you propose should be used in place of ng2-component-loader? We need a loader that can do something similar, with better stability. Or perhaps another way to load component dependencies? We can maybe use file-loader but I initially thought compiling the style+template dependencies directly into the bundle is a plus (I can be convinced otherwise). There's also a possibility of doing something like
The only reason I didn't use |
I used Sorry, I didn't see the use of polyfills (trying to merge webpack configs onto another project). |
Remove ng2-component-loader
Limits to
.component.ts
files, which are a recommended standard in ng2, but some don't adhere to recommended standards (me! IMO, .component.ts is a bloated name extension).The package also has a bug where if you have a component declaration like below:
it won't be recognised.
If you also have multiple
@component
declarations in the same file, you're doomed.The package does a simple job, that is, transform
templateUrl: 'string.pug'
intotemplate: 'pug template contents'
. Writing the require is easier and more transparent than this loader (IMO).webpack-dev-server
consider using this, it makes a file server from webpack and makes things easier.
polyfills
Browsers require
zone.js
andreflect-metadata
polyfills, which should be another chunk. It can be a cached file since it doesn't change often.es5 & ng2 compiler issues
If ng2 is transpiled to es5, you might need to use
awesome-typescript-loader
instead of the typescript loader. It is in angular quickstart, and solves some compiler issues with es5 compatibility.This is mostly a debate, if you agree I can contribute the points above to the package.
The text was updated successfully, but these errors were encountered: