Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Angular v16 #108

Open
martinpeterek opened this issue Jun 14, 2023 · 7 comments
Open

Upgrade to Angular v16 #108

martinpeterek opened this issue Jun 14, 2023 · 7 comments

Comments

@martinpeterek
Copy link

Actual verion of package is incompatible with new Angular

@PSingh-Unipd
Copy link

PSingh-Unipd commented Jul 19, 2023

Any updates on this issue? It seems that changing ModuleWithProviders to ModuleWithProviders<IntercomModule> might solve the issue(inside intercom.module.ts). I would appreciate any insights on this.

@MoustafaMohA
Copy link

I have the same issue when updated to Angular 16.

@PSingh-Unipd
Copy link

@MoustafaMohA This lib was forked some time ago, and it works fine with Angular 16. This is the link to the updated version of this lib: https://www.npmjs.com/package/@supy-io/ngx-intercom

@MoustafaMohA
Copy link

@PSingh-Unipd Thank you for replay, I will try to use the ngx-intercom and update to Angular 16.

@martinpeterek
Copy link
Author

@PSingh-Unipd thank you, it works.

@shardul-shah
Copy link

@MoustafaMohA This lib was forked some time ago, and it works fine with Angular 16. This is the link to the updated version of this lib: https://www.npmjs.com/package/@supy-io/ngx-intercom

@PSingh-Unipd thank you for the link!

For anyone who stumbles here, I just want to comment on this. As of now - March 2024 - this forked package works well with the latest version of Angular - 17. It will work with 16 too. You may need to change your config object you pass to this.intercom.boot() function (I experienced this), because the forked version changes the interfaces a bit from the original ng-intercom package. Just do so if this is the case and you should be good to go.

@Yaseen-Ahmed-N
Copy link

Yaseen-Ahmed-N commented Jul 3, 2024

if i am doing this this.intercom.boot({app_id: environment.intercomAppID, updateOnRouterChange: true}) it gives error that 'updateOnRouterChange' not a known property. Kindly anyone can tell me the interface of this object. @PSingh-Unipd please mention details of the new configuration which working fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants