Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lld: Enable the --local-caprelocs=legacy command line argument #755

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

lld: Enable the --local-caprelocs=legacy command line argument #755

wants to merge 1 commit into from
+1 −1

Conversation

bsdjhb
Copy link
Contributor

@bsdjhb bsdjhb commented Jan 9, 2025

No description provided.

@bsdjhb bsdjhb requested a review from jrtc27 January 9, 2025 19:41
@arichardson
Copy link
Member

Can we target this to upstream-llvm-merge? It would be nice to keep it as a fast-forward merge.

arichardson
arichardson reviewed Jan 9, 2025
View reviewed changes
Copy link
Member

@arichardson arichardson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this was not caught by tests since it's the default...

@bsdjhb
Copy link
Contributor Author

bsdjhb commented Jan 10, 2025

Can we target this to upstream-llvm-merge? It would be nice to keep it as a fast-forward merge.

I will just wait until the merge lands and then rebase it before merging. It is so small it should rebase easily.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arichardson arichardson arichardson left review comments

@jrtc27 jrtc27 jrtc27 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bsdjhb @arichardson @jrtc27