Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refresh_token available without going through consent #25

Open
lhoekenga opened this issue Jun 25, 2019 · 2 comments
Open

refresh_token available without going through consent #25

lhoekenga opened this issue Jun 25, 2019 · 2 comments

Comments

@lhoekenga
Copy link
Contributor

The OIDC extension will issue refresh tokens w/o the RP specifying prompt=consent

Acc'd to https://openid.net/specs/openid-connect-core-1_0.html#OfflineAccess

When offline access is requested, a prompt parameter value of consent MUST be used unless other conditions for processing the request permitting offline access to the requested resources are in place. The OP MUST always obtain consent to returning a Refresh Token that enables offline access to the requested resources. A previously saved user consent is not always sufficient to grant offline access.

Of similar concern, but probably a separate issue - "prompt=consent" only displays consent if relying-party.xml has added the attribute-release flow to OIDC.SSO..

<bean parent="OIDC.SSO" p:postAuthenticationFlows="attribute-release" />

@jalauros
Copy link
Contributor

The OIDC extension relies on having post authentication flow "attribute-release" for asking consent. If you remove it, the consent will not be asked. That should be the case with both of your issues. Add back the "attribute-release" post authentication flow and consent shall be asked in those cases.

@jalauros
Copy link
Contributor

jalauros commented Jun 25, 2019

You should note that there has been a bug for client side storage handling, effectively causing consent being asked over and over again (if client side storage has been used for it). So if that has been the reason to remove the post authentication flow "attribute-release" there is a fix. Use server side storage or wait for 1.1 release or just apply the commit that closes #24 that fixing the client side storage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants