New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Conversation History Refactoring - Clean Architecture #40

Open

milkdromeda opened this issue Dec 11, 2022 · 0 comments

Assignees

Labels

Contributor

milkdromeda commented Dec 11, 2022

While conversation history use cases mostly follow clean architectures, the following violations can be addressed:

The Input Boundaries are used directly. To fix this, a controller should be used. This passes the responsibility of packaging the input data from the client to the controller.
The view depends directly on the presenter. While this may not violate the dependency rule, it follows convention to invert the dependency, such as by using an observer pattern mentioned in issue Conversation History Refactoring - Design Patterns #39

milkdromeda added the enhancement label

milkdromeda self-assigned this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment