Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CFE output files (cat-*.csv) results are all zero #44

Closed
shahab122 opened this issue Nov 14, 2023 · 9 comments
Closed

CFE output files (cat-*.csv) results are all zero #44

shahab122 opened this issue Nov 14, 2023 · 9 comments
Labels
bug Something isn't working

Comments

@shahab122
Copy link

shahab122 commented Nov 14, 2023

Hi everyone, I have run CFE using NGIAB for the Sipsey River basin (VPU # 03W) in Alabama. As I was checking the model outputs (e.g., "cat-117770.csv"), I found all values in the"cat-117770.csv" file to be zero. This is the case for all catchment csv files. I used "latest-86" image as I was running CFE within NGIAB on Black Warrior. I am not sure what went wrong as I followed the steps mentioned here: https://github.com/CIROH-UA/NGIAB-CloudInfra.

Screenshot of results with troute on:
image

Screenshot of results with troute off:
image

@shahab122 shahab122 added the bug Something isn't working label Nov 14, 2023
@shahab122 shahab122 changed the title CFE results are all zeros CFE results are all zero Nov 14, 2023
@arpita0911patel
Copy link
Member

@jameshalgren

@jameshalgren
Copy link
Member

@shahab122. The easy, useless answer is that those are the default values your configurations is asking the SLOTH module to create as gap-filler for a few values that have to be supplied to CFE.

But what we really need to do is:
a) We need to figure out where the real output from your CFE simulations are going (which is what I believe was your real concern; please confirm).
b) We need to figure out if the 0 values for EVAPOTRANS, *ice_fraction, and sloth_smp are valid for the conditions of your simulation or if they were just default values to permit successful simulation. The EVAPOTRANS parameter has a companion parameter in the CFE model that may be taking precedence in the simulation, for instance. Or, the *_ice_fraction value could be valid at zero if there are no freezing temperatures for your simulation.

@arpita0911patel
Copy link
Member

arpita0911patel commented Nov 27, 2023

This is the sloth configuration here that is producing csv output files:

{
    "name": "bmi_c++",
    "params": {
        "name": "bmi_c++",
        "model_type_name": "SLOTH",
        "main_output_variable": "z",
        "init_config": "/dev/null",
        "allow_exceed_end_time": true,
        "fixed_time_step": false,
        "uses_forcing_file": false,
        "model_params": {
            "sloth_ice_fraction_schaake(1,double,m,node)": "0.0",
            "sloth_ice_fraction_xinan(1,double,1,node)": "0.0",
            "sloth_smp(1,double,1,node)": "0.0",
            "EVAPOTRANS": "0.0"
        },
        "library_file": "/dmod/shared_libs/libslothmodel.so",
        "registration_function": "none"
    }
}

@arpita0911patel arpita0911patel changed the title CFE results are all zero CFE output files (cat-*.csv) results are all zero Nov 27, 2023
@hellkite500
Copy link
Collaborator

Two options here, one, change the order of the multi bmi module definitions so that sloth comes first in the list and CFE is last. By default, ngen will only output the output variables of the LAST modules defined in a multi-bmi model definition. The other option is to use the optional configuration key

"output_vars" : [ "Q_OUT", "OTHER_KNOWN_OUTPUT_VAR"]

With this list, you can explicitly define any output variable available in any of the modules, and the order they will appear in the output CSV file.

@arpita0911patel
Copy link
Member

arpita0911patel commented Nov 29, 2023

First option works for me. It produces the output cat-*.csv files with the outputs for both serial and parellel run. Thank you Nels, I will add the updated one to the AWI_002

@arpita0911patel
Copy link
Member

Updated AWI_03W_113060_002.tar.gz in S3 bucket with the new config file.

@arpita0911patel
Copy link
Member

@shahab122, could you please review the most recent updates and confirm that everything appears satisfactory on your end? Please inform us of any issues or concerns. Thank you!

@shahab122
Copy link
Author

shahab122 commented Nov 29, 2023

@arpita0911patel It worked on my end as well. However, I would prefer the output results (i.e., *.flowveldepth.csv files) for each catchment id, not for each time step. So, each *.flowveldepth.csv file should contain all time steps. I think it would make further analysis easier. Thank you!

@arpita0911patel
Copy link
Member

arpita0911patel commented Nov 30, 2023

Thank you Shahab closing this ticket as it generates non zero output cat-*.csv files now.
For the flowveldepth file, created seperate ticket #61

arpita0911patel added a commit that referenced this issue Nov 30, 2023
Config file is updated to resolve Issue #44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants