Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Commit After Design Space Operation with Same Input and Output Optional #18

Open
nroehner opened this issue Jun 28, 2019 · 0 comments

Comments

@nroehner
Copy link
Collaborator

Add a Boolean argument "isCommit" to the JoinDesignSpace, orDesignSpaces, repeatDesignSpaces, andDesignSpaces, and mergeDesignSpaces methods in DesignSpaceService with a default value of true.

If "isCommit" is true, then a merge commit should be created by calling the mergeVersionHistories method as normal. If "isCommit" is false and the arguments of the operator are such that the output design space is also one of the input design spaces, then no merge commit should be created (do not call mergeVersionHistories).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant