Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Retopology Operators break RF if run via Shift+A menu #1322

Open
vxlcoder opened this issue Jun 15, 2024 · 2 comments
Open

Add Retopology Operators break RF if run via Shift+A menu #1322

vxlcoder opened this issue Jun 15, 2024 · 2 comments

Comments

@vxlcoder
Copy link
Contributor

Issue #1321 had a secondary issue that I'm capturing here.

The Add Retopology at Cursor / Active Operators through the Shift+A menu instead of the header menu does absolutely nothing. The following error message would be silently reported to the console.

ERROR (wm.operator): source/blender/windowmanager/intern/wm_event_system.cc:1571 wm_operator_invoke: invalid operator call 'RETOPOFLOW_OT_newtarget_cursor'

The issue is due to the operator defining an invoke method but not an execute method.

vxlcoder added a commit that referenced this issue Jun 15, 2024
since `event` is not used in these operators, switched `invoke` methods
to `execute` for the Add Retopology Operators
@vxlcoder
Copy link
Contributor Author

this issue appears to be fixed now!

Thanks to @JornBoven for helping debug this issue!

You can use this temp link to test it out (same link as in issue #1321): https://www.dropbox.com/scl/fi/tgbmx8b690orvcc31yp7a/RetopoFlow_v4.0.0-alpha-GitHub.zip?rlkey=380tjledg3h3o0c9g3xc1vloo&st=34u2ntfs&dl=0

@JornBoven
Copy link

I can confirm that it works on my side too. Thank you for your attention to this issue~ I appreciate it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants