Create group invite links #834
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Repumba
force-pushed
the
feature/group-invite-link
branch
from
73434b9
to
16cb3b1
Compare
bswck
suggested changes
Nov 23, 2023
| @@ -168,7 +168,7 @@ def _generate_token(self, user_fields, scope, expiration, **extra_fields): | |||
| return token | |||
|
|
|||
| @staticmethod | |||
| def _verify_token(token, fields, scope) -> Optional[Tuple["User", Optional[str]]]: | |||
| def _verify_token(token, fields, scope) -> Optional[Tuple["User", dict]]: | |||
There was a problem hiding this comment.
dict is a generic type (dict[KT, VT]). Its key and value types should be parametrized.
| ) | ||
| if result is None: | ||
| return None | ||
| else: |
There was a problem hiding this comment.
else after return isn't necessary (unless used for performance reasons in an extremely often called function).
| token, | ||
| ["password_ver", "identity_ver"], | ||
| scope=AuthScope.session, | ||
| ) | ||
| if result is None: | ||
| return None | ||
| else: |
There was a problem hiding this comment.
else after return isn't necessary (unless used for performance reasons in an extremely often called function).
| return None if result is None else result[0] | ||
| if result is None: | ||
| return None | ||
| else: |
There was a problem hiding this comment.
else after return isn't necessary (unless used for performance reasons in an extremely often called function).
| raise InternalServerError( | ||
| "SMTP server needed to fulfill this request is" | ||
| " not configured or unavailable." | ||
| ) |
There was a problem hiding this comment.
This is a good place for exception chaining.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request
What is the current behaviour?
You cannot invite users to your group
What is the new behaviour?
You can invite users to group
After inviting, user receives email with link
Invited user can click the link and join your group
You have to be
group adminto invite usersLinks expire after 7 days by default, you can configure it
Test plan
I've added automatic tests
Closing issues
closes #824