You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Inconsistent code formatting, causing problem in detecting changes and testing PRs
( Shows a lot of unnecessary changes in PR and may also introduce unwanted merge conflicts in future) Reference of such a event ( PR had to be reverted due to bugs) -
Original PR - Prevent Dublicate alarms #257
Revert - Revert "Prevent Dublicate alarms" #268
The problem is relevant for Beacon project as well [ https://github.com/CCExtractor/beacon ]
Solution
Adopt the official Dart formatting rules and use the dartfmt tool to automatically format Dart code on commit/push.
Use of linting tools
we can also use flutter drive for automating end-to-end UI testing and automated testing for unit tests and components as well
impact
dartfmt ensures consistent code style across the codebase for cleaner diffs.
Testing ensures that bugs are detected before going into production
Notes
Even if the testing might seem unnecessary at the moment for this application, but I strongly suggest using a linting or a standard formatting to ensure that changes made in PR are easier for maintainers to track and code base remains consistent.
This issue will be divided it into subtasks.
I would like to work on this.
The text was updated successfully, but these errors were encountered:
Current Problems
( Shows a lot of unnecessary changes in PR and may also introduce unwanted merge conflicts in future)
Reference of such a event ( PR had to be reverted due to bugs) -
Original PR - Prevent Dublicate alarms #257
Revert - Revert "Prevent Dublicate alarms" #268
The problem is relevant for Beacon project as well [ https://github.com/CCExtractor/beacon ]
Solution
dartfmt
tool to automatically format Dart code on commit/push.flutter drive
for automating end-to-end UI testing and automated testing for unit tests and components as wellimpact
dartfmt
ensures consistent code style across the codebase for cleaner diffs.Notes
The text was updated successfully, but these errors were encountered: