Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: [Discuss] the need for testing PR #298

Open
AdarshRawat1 opened this issue Jan 4, 2024 · 2 comments
Open

Feature: [Discuss] the need for testing PR #298

AdarshRawat1 opened this issue Jan 4, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request feat

Comments

@AdarshRawat1
Copy link

AdarshRawat1 commented Jan 4, 2024

Current Problems

  • Inconsistent code formatting, causing problem in detecting changes and testing PRs
    ( Shows a lot of unnecessary changes in PR and may also introduce unwanted merge conflicts in future)
    Reference of such a event ( PR had to be reverted due to bugs) -
    Original PR - Prevent Dublicate alarms #257
    Revert - Revert "Prevent Dublicate alarms" #268

The problem is relevant for Beacon project as well [ https://github.com/CCExtractor/beacon ]

Solution

  • Adopt the official Dart formatting rules and use the dartfmt tool to automatically format Dart code on commit/push.
  • Use of linting tools
  • we can also use flutter drive for automating end-to-end UI testing and automated testing for unit tests and components as well

impact

  • dartfmt ensures consistent code style across the codebase for cleaner diffs.
  • Testing ensures that bugs are detected before going into production

Notes

  • Even if the testing might seem unnecessary at the moment for this application, but I strongly suggest using a linting or a standard formatting to ensure that changes made in PR are easier for maintainers to track and code base remains consistent.
  • This issue will be divided it into subtasks.
  • I would like to work on this.
@MarkisDev
Copy link
Collaborator

I'll assign this to you, testing has definitely gotten more important for the application now. Let me know if you get stuck anywhere, happy to help :)

@MarkisDev MarkisDev added enhancement New feature or request feat labels Jan 7, 2024
@Detective-Khalifah
Copy link

The project is definitely growing, and we need a proper method of tracking changes.
I would suggest https://docs.github.com/en/issues/planning-and-tracking-with-projects/learning-about-projects/about-projects, a Trello board, or some other project management solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request feat
Projects
None yet
Development

No branches or pull requests

3 participants