Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CanopenEditor: Exporting to XDD v1.0 format sets wrong type on "Highest sub-index supported" #110

Open
hepr-skylotec opened this issue Apr 24, 2024 · 6 comments · Fixed by #111
Open

CanopenEditor: Exporting to XDD v1.0 format sets wrong type on "Highest sub-index supported" #110

hepr-skylotec opened this issue Apr 24, 2024 · 6 comments · Fixed by #111
Assignees
@nimrof @trojanobelix
Labels
bug Something isn't working 📭 needs: author feedback More info/confirmation awaited from OP; issues typically get closed after 30 days of inactivity

Comments

@hepr-skylotec
Copy link

When using ARRAY types and exporting to XDD v1.0 "old" format, the 0x00 index of the arrays "Highest sub-index supported" gets the same type as the array elements in index 1 and up.

For SDOs of ARRAY type, the 0x00 index "Highest sub-index supported" is always an UNSIGNED8, regardless of the type used for the array elements. The editor handles this correctly in code generation and XDD v1.1 format but wrong in XDD v1.0 format export.

The CANopenObject for subindex 0 has the dataType attribute set to the same value as the rest of the subindex entries in the array. The dataType attribute should always be 0005 whic is for UNSIGNED8

CanopenEditor version : v4.2.0-0-g3735e28 on Windows 11

Current output:

          <CANopenObject index="220B" name="Temperatures" objectType="8" lowLimit="" highLimit="" actualValue="" denotation="" edseditor_extenstion_storagelocation="RAM" edseditor_extension_notifyonchange="false" PDOmapping="TPDO" uniqueIDRef="UID_PARAM_220b" subNumber="9">
            <CANopenSubObject edseditor_extension_notifyonchange="false" subIndex="0000" name="Highest sub-index supported" objectType="7" dataType="0008" lowLimit="" highLimit="" accessType="ro" actualValue="" denotation="" PDOmapping="no" uniqueIDRef="UID_PARAM_220b00" />
            <CANopenSubObject edseditor_extension_notifyonchange="false" subIndex="0001" name="FET Temperature Discharge" objectType="7" dataType="0008" lowLimit="" highLimit="" accessType="ro" actualValue="" denotation="" PDOmapping="TPDO" uniqueIDRef="UID_PARAM_220b01" />
            <CANopenSubObject edseditor_extension_notifyonchange="false" subIndex="0002" name="FET Temperature Charge" objectType="7" dataType="0008" lowLimit="" highLimit="" accessType="ro" actualValue="" denotation="" PDOmapping="TPDO" uniqueIDRef="UID_PARAM_220b02" />
            <CANopenSubObject edseditor_extension_notifyonchange="false" subIndex="0003" name="Cell Temperature - AFE 1" objectType="7" dataType="0008" lowLimit="" highLimit="" accessType="ro" actualValue="" denotation="" PDOmapping="TPDO" uniqueIDRef="UID_PARAM_220b03" />
            <CANopenSubObject edseditor_extension_notifyonchange="false" subIndex="0004" name="Cell Temperature - AFE 2" objectType="7" dataType="0008" lowLimit="" highLimit="" accessType="ro" actualValue="" denotation="" PDOmapping="TPDO" uniqueIDRef="UID_PARAM_220b04" />
            <CANopenSubObject edseditor_extension_notifyonchange="false" subIndex="0005" name="Cell Temperature - Gauge" objectType="7" dataType="0008" lowLimit="" highLimit="" accessType="ro" actualValue="" denotation="" PDOmapping="TPDO" uniqueIDRef="UID_PARAM_220b05" />
            <CANopenSubObject edseditor_extension_notifyonchange="false" subIndex="0006" name="Internal Temperature AFE" objectType="7" dataType="0008" lowLimit="" highLimit="" accessType="ro" actualValue="" denotation="" PDOmapping="TPDO" uniqueIDRef="UID_PARAM_220b06" />
            <CANopenSubObject edseditor_extension_notifyonchange="false" subIndex="0007" name="Internal Temperature Fuel Gauge" objectType="7" dataType="0008" lowLimit="" highLimit="" accessType="ro" actualValue="" denotation="" PDOmapping="TPDO" uniqueIDRef="UID_PARAM_220b07" />
            <CANopenSubObject edseditor_extension_notifyonchange="false" subIndex="0008" name="Internal Temperarure MCU" objectType="7" dataType="0008" lowLimit="" highLimit="" accessType="ro" actualValue="" denotation="" PDOmapping="TPDO" uniqueIDRef="UID_PARAM_220b08" />
          </CANopenObject>

Expected output:

          <CANopenObject index="220B" name="Temperatures" objectType="8" lowLimit="" highLimit="" actualValue="" denotation="" edseditor_extenstion_storagelocation="RAM" edseditor_extension_notifyonchange="false" PDOmapping="TPDO" uniqueIDRef="UID_PARAM_220b" subNumber="9">
            <CANopenSubObject edseditor_extension_notifyonchange="false" subIndex="0000" name="Highest sub-index supported" objectType="7" dataType="0005" lowLimit="" highLimit="" accessType="ro" actualValue="" denotation="" PDOmapping="no" uniqueIDRef="UID_PARAM_220b00" />
            <CANopenSubObject edseditor_extension_notifyonchange="false" subIndex="0001" name="FET Temperature Discharge" objectType="7" dataType="0008" lowLimit="" highLimit="" accessType="ro" actualValue="" denotation="" PDOmapping="TPDO" uniqueIDRef="UID_PARAM_220b01" />
            <CANopenSubObject edseditor_extension_notifyonchange="false" subIndex="0002" name="FET Temperature Charge" objectType="7" dataType="0008" lowLimit="" highLimit="" accessType="ro" actualValue="" denotation="" PDOmapping="TPDO" uniqueIDRef="UID_PARAM_220b02" />
            <CANopenSubObject edseditor_extension_notifyonchange="false" subIndex="0003" name="Cell Temperature - AFE 1" objectType="7" dataType="0008" lowLimit="" highLimit="" accessType="ro" actualValue="" denotation="" PDOmapping="TPDO" uniqueIDRef="UID_PARAM_220b03" />
            <CANopenSubObject edseditor_extension_notifyonchange="false" subIndex="0004" name="Cell Temperature - AFE 2" objectType="7" dataType="0008" lowLimit="" highLimit="" accessType="ro" actualValue="" denotation="" PDOmapping="TPDO" uniqueIDRef="UID_PARAM_220b04" />
            <CANopenSubObject edseditor_extension_notifyonchange="false" subIndex="0005" name="Cell Temperature - Gauge" objectType="7" dataType="0008" lowLimit="" highLimit="" accessType="ro" actualValue="" denotation="" PDOmapping="TPDO" uniqueIDRef="UID_PARAM_220b05" />
            <CANopenSubObject edseditor_extension_notifyonchange="false" subIndex="0006" name="Internal Temperature AFE" objectType="7" dataType="0008" lowLimit="" highLimit="" accessType="ro" actualValue="" denotation="" PDOmapping="TPDO" uniqueIDRef="UID_PARAM_220b06" />
            <CANopenSubObject edseditor_extension_notifyonchange="false" subIndex="0007" name="Internal Temperature Fuel Gauge" objectType="7" dataType="0008" lowLimit="" highLimit="" accessType="ro" actualValue="" denotation="" PDOmapping="TPDO" uniqueIDRef="UID_PARAM_220b07" />
            <CANopenSubObject edseditor_extension_notifyonchange="false" subIndex="0008" name="Internal Temperarure MCU" objectType="7" dataType="0008" lowLimit="" highLimit="" accessType="ro" actualValue="" denotation="" PDOmapping="TPDO" uniqueIDRef="UID_PARAM_220b08" />
          </CANopenObject>
@nimrof nimrof added the bug Something isn't working label Apr 27, 2024
@nimrof nimrof self-assigned this Apr 27, 2024
@nimrof nimrof mentioned this issue Apr 27, 2024
Merged
@nimrof nimrof linked a pull request Apr 27, 2024 that will close this issue
110 canopeneditor exporting to xdd v10 format sets wrong type on highest sub index supported #111
Merged
@nimrof
Copy link
Collaborator

nimrof commented Apr 27, 2024

Thanks for reporting the bug @hepr-skylotec,
It var very easy to reproduce with the information you gave us.

Got a bugfix ready if you want to test it out now:
https://github.com/CANopenNode/CANopenEditor/actions/runs/8859150670/artifacts/1453226221

@hepr-skylotec
Copy link
Author

@nimrof Hi, thanks for the fix.

Unfortunatlely I still see the issue with the build you provided when exporting to "CANopen XDD v1.0, old" format. Output from the exporter is exactly the same with the build you provided, as with my older 4.2.0 version.

Perhaps the fix did not get included in the build?

@nimrof nimrof reopened this Apr 29, 2024
@trojanobelix
Copy link
Collaborator

What is the current status? Close it?

@hepr-skylotec
Copy link
Author

It looks like this is still broken in v4.2.2-0-g07966bd

@trojanobelix trojanobelix self-assigned this Nov 14, 2024
trojanobelix added a commit that referenced this issue Nov 14, 2024
@trojanobelix
bugfix #110
956d0fc
@trojanobelix trojanobelix mentioned this issue Nov 14, 2024
Open
@trojanobelix trojanobelix added the 📭 needs: author feedback More info/confirmation awaited from OP; issues typically get closed after 30 days of inactivity label Nov 14, 2024
@trojanobelix
Copy link
Collaborator

@hepr-skylotec Please test if it solves the problem.

@hepr-skylotec
Copy link
Author

@trojanobelix This seems to fix the issue. Subindex 01 now consistently gets datatype="0005" for Arrays and Records when exporting my dictionary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nimrof nimrof

@trojanobelix trojanobelix

Labels
bug Something isn't working 📭 needs: author feedback More info/confirmation awaited from OP; issues typically get closed after 30 days of inactivity
Projects
None yet
Milestone
No milestone
3 participants
@nimrof @trojanobelix @hepr-skylotec