Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lastest Overhaul Questions & Suggestions #53

Open
Squimbert opened this issue Nov 13, 2024 · 4 comments
Open

Lastest Overhaul Questions & Suggestions #53

Squimbert opened this issue Nov 13, 2024 · 4 comments

Comments

@Squimbert
Copy link

  1. What are the first 3 profiles in the drop down shown in my the following screenshot? I don't have those profiles under Enemies.
    image

  2. Many modules do not have Module specific settings. Consider removing the Module specific settings tabs on these since it can't be clicked. Example in the following screenshot.
    image

  3. When in test mode, "My target" and "My Focus" borders do not show. Consider adding one of each for testing purposes. See following screenshot.
    image

  4. Consider merging "More Profile Options" "Import profile" and "Export profile" into "Profiles". Would be cleaner and more practical.
    image

  5. Consider renaming the button from "X" to "Delete Profile". More logical. See following screenshot.
    image

I will add to this as I have more things to suggest. Great job! Loving it.

@bullsei
Copy link
Member

bullsei commented Nov 14, 2024

Hi Squimbert

First of all, great post you made, really love the screenshots, thanks for taking your time creating your post. Highly appreciated.

  1. So how it works right now there are basically 2 sets of player count settings. One set is the default basic set 1 to 5, 6 to 15 and 6 to 40 players, second set is the custom set players basically switch to by enabling the custom player count options. So what custom refers to is the second (custom set) and the one without special labling is the still existing normal ones. So basically it enables the user to create the custom player count profiles based on already modified basic playercount profiles. But i definitely agree that this is not great in terms of user experience. Maybe it would be better to simply remove the basic set ones from the dropdown list? Maybe i should just add a label to there too, aka "basic" or something like that or a longer explanation text to the dropdown. I also thought about still showing the 3 tabs for basic set but not making them clickable, maybe that would be better?
  2. Not much to say here, i will change that :)
  3. Great idea too, I dont' know why i haven't thought of that in all these years
  4. I dont think this one is possible. The profile tab is the default profile tab created by the library used for the configuration panel/profile settings.
  5. Good idea too, I kinda tried to be a bit too fancy and save Button space for no reason haha

Keep the feedback coming, this is hands down one of the best feedbacks i have gotten in all the years :)

@Squimbert
Copy link
Author

  1. Yeah it's a bit confusing. I would leave them if they are configured decently as starting points. Maybe just add something in their name like "Template" or similar to clarify?

2, 3, 5. Thanks for the update!

  1. That's fine, it's minor anyway.

I will be doing some blitz soon-ish and will keep an eye out for anything I think could use changing and if I find anything I'll report back here.

I'm glad I can be a part of it and help :)

@Squimbert
Copy link
Author

Now that I think of it... is there any way to replace the default blizzard flag/orb carrier frames in battlegrounds with BGE arena frames, but disable both BGE and Blizzard arena frames to use Sarena or similar while in arenas?

@bullsei
Copy link
Member

bullsei commented Nov 17, 2024

regarding the first point: i guess i will just add some sort of a short icon or special character like a * or something to the custom ones and leave the other 3 as is but still show them but disabled.

About your last question, that would require quite some changes in bge to basically have and additonal main frame (besides the existing ones for enemies and allies) with its own proflile and basically mixed allies/enemies shown in it, it would be doable but i feel like this would be a bit too special to be added to the addon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants