From 44aa33267ad0705d440d3dd1516b313cc6bea5cd Mon Sep 17 00:00:00 2001 From: Bremmers Date: Sun, 5 May 2024 16:08:20 +0200 Subject: [PATCH] feedback from Timo --- include/clap/ext/draft/midici-profiles.h | 62 ++++++++++++------------ 1 file changed, 31 insertions(+), 31 deletions(-) diff --git a/include/clap/ext/draft/midici-profiles.h b/include/clap/ext/draft/midici-profiles.h index c9566417..891354fe 100644 --- a/include/clap/ext/draft/midici-profiles.h +++ b/include/clap/ext/draft/midici-profiles.h @@ -76,12 +76,12 @@ typedef struct clap_plugin_midici_profiles { // The "enumerating profiles" paragraph above describes what's supposed to be in the list. // [main-thread] uint32_t(CLAP_ABI *count)(const clap_plugin_t *plugin, - uint16_t port_index); + uint32_t port_index); // Get a clap_profile_t by index. // [main-thread] bool(CLAP_ABI *get)(const clap_plugin_t *plugin, - uint16_t port_index, + uint32_t port_index, uint32_t profile_index, clap_profile_t *profile); @@ -95,13 +95,13 @@ typedef struct clap_plugin_midici_profiles { // The profile targeted by channel/num_channels should generally be enabled before calling this function. // In some cases profile detals like available channels are needed before enabling a profile. Plugins should make sure this is handled correctly. // [main-thread] - bool(CLAP_ABI *get_details)(const clap_plugin_t *plugin, - uint16_t port_index, - const clap_profile_id_t profile_id, - uint8_t channel, - uint16_t num_channels, - uint8_t inquiry_target, - const clap_ostream_t *stream); + bool(CLAP_ABI *get_details)(const clap_plugin_t *plugin, + uint32_t port_index, + const clap_profile_id_t *profile_id, + uint8_t channel, + uint16_t num_channels, + uint8_t inquiry_target, + const clap_ostream_t *stream); // Send Profile Specific Data to profile at channel/num_channels. // Returns true if data was accepted @@ -109,13 +109,13 @@ typedef struct clap_plugin_midici_profiles { // Example: MPE Channel Response Type Notification would be F0 01 F7 // A profile may specify multiple data messages. It's recommended to send the complete 'state' in a single set_data() call. // [main-thread] - bool(CLAP_ABI *set_data)(const clap_plugin_t *plugin, - uint16_t port_index, - const clap_profile_id_t profile_id, - uint8_t channel, - uint16_t num_channels, - const uint8_t *buffer, - uint32_t buffer_size); + bool(CLAP_ABI *set_data)(const clap_plugin_t *plugin, + uint32_t port_index, + const clap_profile_id_t *profile_id, + uint8_t channel, + uint16_t num_channels, + const uint8_t *buffer, + uint32_t buffer_size); // Enables a profile at channel/num_channels. // Returns true if the profile is enabled at channel/num_channels when the function returns. @@ -124,22 +124,22 @@ typedef struct clap_plugin_midici_profiles { // Note for hosts: after calling this function count()/get() may have changed !! // Note for plugins: do not call clap_host_midici_profiles.changed. // [main-thread] - bool(CLAP_ABI *enable)(const clap_plugin_t *plugin, - uint16_t port_index, - const clap_profile_id_t profile_id, - uint8_t channel, - uint16_t num_channels); + bool(CLAP_ABI *enable)(const clap_plugin_t *plugin, + uint32_t port_index, + const clap_profile_id_t *profile_id, + uint8_t channel, + uint16_t num_channels); // Disables a profile at channel/num_channels. // Returns true if the profile isn't enabled at channel/num_channels when the function returns. // Note for hosts: after calling this function count()/get() may have changed !! // Note for plugins: do not call clap_host_midici_profiles.changed. // [main-thread] - bool(CLAP_ABI *disable)(const clap_plugin_t *plugin, - uint16_t port_index, - const clap_profile_id_t profile_id, - uint8_t channel, - uint16_t num_channels); + bool(CLAP_ABI *disable)(const clap_plugin_t *plugin, + uint32_t port_index, + const clap_profile_id_t *profile_id, + uint8_t channel, + uint16_t num_channels); } clap_plugin_midici_profiles_t; typedef struct clap_host_midici_profiles { @@ -150,11 +150,11 @@ typedef struct clap_host_midici_profiles { // Plugins calls this if host needs to read Profile Specific Data Messages again. // Host calls get_details(.., port_index, profile, channel, num_channels, CLAP_MIDICI_PROFILES_INQUIRY_TARGET_DATA, ..). // [main-thread] - void(CLAP_ABI *datachanged)(const clap_host_t *host, - uint16_t port_index, - const clap_profile_id_t profile_id, - uint8_t channel, - uint16_t num_channels); + void(CLAP_ABI *datachanged)(const clap_host_t *host, + uint32_t port_index, + const clap_profile_id_t *profile_id, + uint8_t channel, + uint16_t num_channels); } clap_host_midici_profiles_t; #ifdef __cplusplus