Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Callbacks to IBranchLinkShareInterface are never called #138

Open
yonkahlon opened this issue Sep 22, 2021 · 0 comments
Open

Callbacks to IBranchLinkShareInterface are never called #138

yonkahlon opened this issue Sep 22, 2021 · 0 comments

Comments

@yonkahlon
Copy link

After running GetShortURL(), the ReceivedUrl callback method is successfully called (part of IBranchUrlInterface):

Branch.GetInstance().GetShortURL(this, _branchObj, _linkProperties);

When I call ShareLink() in the ReceivedUrl callback, none of the IBranchLinkShareInterface methods are called to let me know what the user did.

Branch.GetInstance().ShareLink(this, _branchObj, _linkProperties, "[My message text]");

If you go to the Branch-Xamarin-SDK.iOS project, and look at BranchIOS.cs, there is this code:

public override void ShareLink (IBranchLinkShareInterface callback,
			BranchUniversalObject universalObject,
			BranchLinkProperties linkProperties,
			string message)
{
	IOSNativeBranch.BranchUniversalObject buo = BranchIOSUtils.ToNativeUniversalObject (universalObject);
	IOSNativeBranch.BranchLinkProperties blp = BranchIOSUtils.ToNativeLinkProperties (linkProperties);
	UIKit.UIWindow window = UIKit.UIApplication.SharedApplication.KeyWindow;
	buo.ShowShareSheetWithLinkProperties (blp, message, window.RootViewController, delegate(string url, bool isShared) { });
}

Nothing is being done when buo.ShowShareSheetWithLinkProperties is complete (you can see there is just an empty delegate. An IBranchLinkShareInterface object is passed to this method, so I wonder if it should be used in the completion delegate?

@yonkahlon yonkahlon changed the title Callbacks to IBranchLinkShareInterface are neve called Callbacks to IBranchLinkShareInterface are never called Sep 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant