Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve ability to configure DynamoDB Client and/or expose ability to provide DynamoDB Client #277

Open
coreyjv opened this issue Aug 4, 2021 · 0 comments

Comments

@coreyjv
Copy link

coreyjv commented Aug 4, 2021

In reviewing the source for the project here I noticed that it's making a global configuration update instead of providing these options to the DocumentClient constructor which is supported as noted here and here. It would seem it would be best to transition these to use the constructor instead of the global config.

This raises a further question though. What if a user had the need to configure additional properties for the DocumentClient that this library chose not to expose?

I see a few potential ways to proceed:

  1. Keep the public API of the package the same and transition to use the constructor for a more narrow configuration update but this prevents any other options from being configured.
  2. Add to the public API essentially exposing all configuration options for DocumentClient.
  3. Expose the ability to provide an instance of the DocumentClient in a non-breaking change.
  4. Expose the ability to provide an instance of the DocumentClient in a breaking change.

I'm more than happy to submit a pull request to make any adjustments but I wanted to understand if this is a change that would be considered and what the preferred option would be.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant