Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RU] Decode pronunciations #1376

Open
BoboTiG opened this issue Sep 2, 2022 · 0 comments · May be fixed by #2195
Open

[RU] Decode pronunciations #1376

BoboTiG opened this issue Sep 2, 2022 · 0 comments · May be fixed by #2195
Assignees
@BoboTiG
Labels
Fund locale:Russian

Comments

@BoboTiG
Copy link
Owner

BoboTiG commented Sep 2, 2022 •
edited by polar-sh bot
Loading

Russian pronunciations are using the transcriptions-ru LUA script. We should port it to Python to display proper pronunciations.

Note that it will be easier to tackle after #1174.

Upvote & Fund

  • We're using Polar.sh so you can upvote and help fund this issue.
  • We receive the funding once the issue is completed & confirmed by you.
  • Thank you in advance for helping prioritize & fund our backlog.
Fund with Polar
BoboTiG added a commit that referenced this issue Sep 2, 2022
@BoboTiG
Pronunciations refactoring
278c4c2 
I reviewed completely how pronunciations were retrieved in order
to tackle that task, including changing where pronunciations were
looked for: before we were using the whole word wikicode, now we
only use `head_sections` wikicode (faster, and more efficient).

It has the following nice side-effects (on top the having
local-specific formatting like `\...\` for French, `[...]` for German, etc.):

- `EN`, `FR`: now supports multiple cross-sections pronunciations
  (like ones from Middle English combined to ones from Old English
  sections, for instance on English data)
- `FR`: pronunciations outside the French section are no more taken
  into account (like using values from Gaulois or other locale sections,
  that was incorrect)
- `PT`: a lot more pronunciations are correctly found now
- `SV`: multiple pronunciations are now supported
- `RU`: it will be way easier to tackle #1376 then
@BoboTiG BoboTiG mentioned this issue Sep 2, 2022
Merged
BoboTiG added a commit that referenced this issue Sep 3, 2022
@BoboTiG
Pronunciations refactoring
add2c9a 
I reviewed completely how pronunciations were retrieved in order
to tackle that task, including changing where pronunciations were
looked for: before we were using the whole word wikicode, now we
only use `head_sections` wikicode (faster, and more efficient).

It has the following nice side-effects (on top the having
local-specific formatting like `\...\` for French, `[...]` for German, etc.):

- `EN`, `FR`: now supports multiple cross-sections pronunciations
  (like ones from Middle English combined to ones from Old English
  sections, for instance on English data)
- `FR`: pronunciations outside the French section are no more taken
  into account (like using values from Gaulois or other locale sections,
  that was incorrect)
- `PT`: a lot more pronunciations are correctly found now
- `SV`: multiple pronunciations are now supported
- `RU`: it will be way easier to tackle #1376 then
@polar-sh polar-sh bot added the Fund label Jul 23, 2024
@BoboTiG BoboTiG self-assigned this Oct 15, 2024
@BoboTiG BoboTiG linked a pull request Oct 16, 2024 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BoboTiG BoboTiG

Labels
Fund locale:Russian
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[RU] Decode pronunciations BoboTiG/ebook-reader-dict
1 participant
@BoboTiG