Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid JSON in type summation examples #34

Open
joni-herttuainen opened this issue Nov 15, 2023 · 0 comments
Open

Invalid JSON in type summation examples #34

joni-herttuainen opened this issue Nov 15, 2023 · 0 comments

Comments

@joni-herttuainen
Copy link
Contributor

joni-herttuainen commented Nov 15, 2023

In type summation examples, the line with variable_name contains incorrect JSON:

       "cell_imembrane": {
           "cells": "Column",
           "sections": "soma",
           "type": "summation",
           "variable_name": "i_membrane", "IClamp",  # <-- this one
           "unit": "nA",
           "start_time": 0,
           "end_time": 500,
           "enabled": true
       }

moreover, we have the same issue in the description of variable_name:

...For summation type, can sum multiple variables by indicating as a comma separated strings. e.g. "ina", "ik"

How should these be defined?

  • "'ina', 'ik'"
  • "ina, ik"
  • ["ina", "ik"]
    • if so, variable_name should be defined as a list/array instead of text

EDIT: I believe @WeinaJi , @jamesgking can provide an answer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant