Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What should we do with "CellBody" elements ? #158

Open
wizmer opened this issue Feb 6, 2020 · 1 comment
Open

What should we do with "CellBody" elements ? #158

wizmer opened this issue Feb 6, 2020 · 1 comment

Comments

@wizmer
Copy link
Contributor

wizmer commented Feb 6, 2020

In ASC format, a soma is usually defined my the starting token (CellBody).
However in some cases, it happens that this token is missing but the "CellBody" token is there instead.

Here is an example extracted from a real file:

("CellBody"
  (Color Green)
  (Closed)
  (GUID "9C6D866499E44219B0F15069BE9FD825")
  (MBFObjectType 5)
  (FillDensity 0)
  (Resolution 0.073746)
  (   35.70    -4.72     8.60     0.07)  ;  4, 1
  (   38.25    -3.55     8.60     0.07)  ;  4, 2
  (   40.20    -2.73     8.60     0.07)  ;  4, 3
  (   42.23    -1.47     8.60     0.07)  ;  4, 4
... the file continues

If I'm correctly interpreting @jdcourcol's sayings, this quoted CellBody is simply a comment written by the user. It is not the official token that should be present.

The question is: Should this kind of soma be valid or not ? I know we had issues when we tried to allow such kind of soma in the past. That's why the following line is commented in the code https://github.com/wizmer/MorphIO/blob/master/src/readers/lex.cpp#L158
I don't remember why though.

@jdcourcol
Copy link
Contributor

it seems neurostr is looking for the tag CellBody as well.
https://github.com/lrodriguezlujan/neurostr/blob/master/src/io/ASCParser.cpp#L381

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants