Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set tokenSupply variable and check against it when minting #5

Open
fordN opened this issue Sep 22, 2021 · 3 comments
Open

Set tokenSupply variable and check against it when minting #5

fordN opened this issue Sep 22, 2021 · 3 comments
Labels
enhancement New feature or request

Comments

@fordN
Copy link
Member

fordN commented Sep 22, 2021

Title is self explanatory.

@fordN fordN added the enhancement New feature or request label Sep 22, 2021
@jaredcosulich
Copy link
Contributor

Right now the setup takes a "initialExpectedTokenSupply". Do we need a separate variable to hold the actual tokenSupply? I'm not sure I understand what the "expected" descriptor is for. Could we just set the tokenSupply in the setup and then check against that when mintBlank is called?

@fordN
Copy link
Member Author

fordN commented Oct 15, 2021

@jaredcosulich yeah I think we just need to set a tokenSupply variable and then check against that when minting. I've updated the issue name accordingly and we can use this to track the work.

@fordN fordN changed the title Feature: Limit overall supply Set tokenSupply variable and check against it when minting Oct 15, 2021
@asebesta
Copy link
Contributor

asebesta commented Nov 2, 2021

@jaredcosulich @fordN - I should have tagged this one in the latest commit. Once you've had a chance to review I think it can be closed, but let me know. a1b9492

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants