Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

monads: core_kernel.rope no longer exists in v0.16 #1589

Open
bmourad01 opened this issue Jun 23, 2023 · 3 comments
Open

monads: core_kernel.rope no longer exists in v0.16 #1589

bmourad01 opened this issue Jun 23, 2023 · 3 comments

Comments

@bmourad01
Copy link
Contributor

bmourad01 commented Jun 23, 2023 •
edited
Loading

It seems this functionality has been separated into the jane_rope package (which currently depends on base v0.16). Would we need to break compatibility with previous versions (i.e. < v0.16.0) of janestreet libraries to upgrade, or hard stop at v0.15? Perhaps a third option exists?

ping @ivg
@ivg
Copy link
Member

ivg commented Jun 23, 2023

Do you mean by a hard stop that we shouldn't support versions below v0.15 or above?

@bmourad01
Copy link
Contributor Author

By that I mean that one option would be to not support anything above v0.15.

@XVilka
Copy link
Contributor

XVilka commented Jun 27, 2023 •
edited
Loading

It's better to support newer Core/Base versions in my opinion, since they will benefit from all the OCaml 5.x multicore and effects work in the future, which would fit BAP quite well for variety of reasons. See also #1561

@bmourad01 bmourad01 mentioned this issue Apr 13, 2024
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@XVilka @ivg @bmourad01